Re: [PATCH 3/3] reader: Use xmlFirstElementChild/xmlNextElementSibling to iterate over children elements

[Dodji Seketeli <dodji@seketeli.org>]

Hello,

[...]

Dodji Seketeli <dodji@seketeli.org> a écrit:

> Hello Giuliano,
>
> Giuliano Procida <gprocida@google.com> a écrit:
>
>
>> I had a quick look and there's (at least) one place where there still a
>> direct access to ->children. The code works because there are separate
>> tests to not process wrong nodes, but it would be neater to use the first
>> element child function uniformly (as well).
>
> You are right.
>
> Below is an update of that patch that hopefully addresses your comment.
>
> Thanks.
>
> From 0a6c322f6ec8be354122c6b4cdefe6143eb568ed Mon Sep 17 00:00:00 2001
> From: Dodji Seketeli <dodji@redhat.com>
> Date: Mon, 19 Apr 2021 13:50:33 +0200
> Subject: [PATCH 3/3] reader: Use xmlFirstElementChild/xmlNextElementSibling to
>  iterate over children elements
>
> Use xmlFirstElementChild/xmlNextElementSibling to iterate over element
> children nodes rather than doing it by hand in the various for loops.
>
> 	* src/abg-reader.cc (walk_xml_node_to_map_type_ids)
> 	(read_translation_unit, read_translation_unit_from_input)
> 	(read_symbol_db_from_input, build_needed)
> 	(read_elf_needed_from_input, read_corpus_group_from_input)
> 	(build_namespace_decl, build_elf_symbol_db, build_function_decl)
> 	(build_function_type, build_array_type_def, build_enum_type_decl)
> 	(build_class_decl, build_union_decl, build_function_tdecl)
> 	(build_class_tdecl, build_type_composition)
> 	(build_template_tparameter): Use
> 	xmlFirstElementChild/xmlNextElementSibling rather than poking at
> 	xmlNode::children and looping over xmlNode::next by hand.
>
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>

I have just applied these 3 patches to master.  I forgot to do this
after I posted the patches and saw no follow-up here.

Thanks for the review!

[...]

Cheers,

-- 
		Dodji