* [PATCH] abg-ir.cc: Fix incorrect pop of compared types.
@ 2020-07-15 8:17 Giuliano Procida
2020-07-28 13:32 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2020-07-15 8:17 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida
In one case there is an attempt to "pop" an in-progress type
comparison which hasn't actually happened.
This commit fixes this.
* src/abg-ir.cc (equals): In the class_or_union overload,
replace one instance of RETURN(false) with return false.
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
src/abg-ir.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/src/abg-ir.cc b/src/abg-ir.cc
index 757605f8..6040e1d7 100644
--- a/src/abg-ir.cc
+++ b/src/abg-ir.cc
@@ -19380,7 +19380,7 @@ equals(const class_or_union& l, const class_or_union& r, change_kind* k)
{
if (k)
*k |= LOCAL_TYPE_CHANGE_KIND;
- RETURN(false);
+ return false;
}
if (types_defined_same_linux_kernel_corpus_public(l, r))
--
2.27.0.389.gc38d7665816-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] abg-ir.cc: Fix incorrect pop of compared types.
2020-07-15 8:17 [PATCH] abg-ir.cc: Fix incorrect pop of compared types Giuliano Procida
@ 2020-07-28 13:32 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2020-07-28 13:32 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team
Giuliano Procida <gprocida@google.com> a écrit:
> In one case there is an attempt to "pop" an in-progress type
> comparison which hasn't actually happened.
>
> This commit fixes this.
>
> * src/abg-ir.cc (equals): In the class_or_union overload,
> replace one instance of RETURN(false) with return false.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Good catch!
Applied to master, thanks!
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-07-28 13:32 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-07-15 8:17 [PATCH] abg-ir.cc: Fix incorrect pop of compared types Giuliano Procida
2020-07-28 13:32 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).