From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com
Subject: Re: [PATCH v2] Fix maybe_report_data_members_replaced_by_anon_dm
Date: Tue, 04 Aug 2020 18:28:18 +0200 [thread overview]
Message-ID: <87lfiue5p9.fsf@seketeli.org> (raw)
In-Reply-To: <20200723083543.3143442-1-gprocida@google.com> (Giuliano Procida's message of "Thu, 23 Jul 2020 09:35:42 +0100")
Giuliano Procida <gprocida@google.com> a écrit:
[...]
>
> * src/abg-reporter-priv.cc
> (maybe_report_data_members_replaced_by_anon_dm): Move
> declarations of anonymous_data_member and
> dms_replaced_by_same_anon_dm into inner loop. Use
> anonymous_data_member for testing and reporting, allowing
> iterators i and j to be replaced by just iterator i. Push
> first decl onto dms_replaced_by_same_anon_dm unconditionally
> and move control flow logic into loop condition.
> * tests/data/Makefile.am: Add new test cases.
> * tests/data/test-diff-filter/test-PR25661-7-report-1.txt: New
> test case file.
> * tests/data/test-diff-filter/test-PR25661-7-report-2.txt:
> Likewise.
> * tests/data/test-diff-filter/test-PR25661-7-report-3.txt:
> Likewise.
> * tests/data/test-diff-filter/test-PR25661-7-report-4.txt:
> Likewise.
> * tests/data/test-diff-filter/test-PR25661-7-v0.c: Likewise.
> * tests/data/test-diff-filter/test-PR25661-7-v0.o: Likewise.
> * tests/data/test-diff-filter/test-PR25661-7-v1.c: Likewise.
> * tests/data/test-diff-filter/test-PR25661-7-v1.o: Likewise.
> * tests/test-diff-filter.cc: Call new test cases.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
Cheers,
--
Dodji
prev parent reply other threads:[~2020-08-04 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-22 10:55 [PATCH] " Giuliano Procida
2020-07-23 8:35 ` [PATCH v2] " Giuliano Procida
2020-08-04 16:28 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87lfiue5p9.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).