From: Dodji Seketeli <dodji@redhat.com>
To: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
Cc: libabigail@sourceware.org
Subject: [PATCH, request-for-review] Update CTF's ctf_dict_t detection
Date: Mon, 16 Jan 2023 10:11:08 +0100 [thread overview]
Message-ID: <87mt6ivo7n.fsf@redhat.com> (raw)
Hello,
As ctf_dict_t can be an opaque type depending on the version of
ctf-api.h, using AC_CHECK_TYPE won't work to detect it because that
macro invokes sizeof(ctf_dict_t).
With this change, we don't require that ctf_dict_t be fully defined.
* configure.ac: Use AC_COMPILE_IFELSE to try and compile a code
snippet that doesn't need that ctf_dict_t be fully defined.
Would this be OK to commit?
Thanks.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
configure.ac | 11 ++++++-----
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/configure.ac b/configure.ac
index d19c2f96..4d214b1c 100644
--- a/configure.ac
+++ b/configure.ac
@@ -334,11 +334,12 @@ if test x$ENABLE_CTF != xno; then
fi
if test x$LIBCTF = xyes; then
- dnl Test if struct btf_enum64 is present.
- AC_CHECK_TYPE([struct ctf_dict_t],
- [HAVE_CTF_DICT_T=yes],
- [HAVE_CTF_DICT_T=no],
- [#include <ctf-api.h>])
+ dnl Test if struct struct ctf_dict_t is present.
+ AC_LANG(C++)
+ AC_COMPILE_IFELSE([AC_LANG_SOURCE([[#include <ctf-api.h>
+ ctf_dict_t* c;]])],
+ [HAVE_CTF_DICT_T=yes],
+ [HAVE_CTF_DICT_T=no])
if test x$HAVE_CTF_DICT_T = xyes; then
AC_DEFINE([HAVE_CTF_DICT_T], 1, [struct ctf_dict_t is present])
--
2.31.1
--
Dodji
next reply other threads:[~2023-01-16 16:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 9:11 Dodji Seketeli [this message]
2023-01-16 16:35 ` Guillermo E. Martinez
2023-01-16 17:42 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt6ivo7n.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=guillermo.e.martinez@oracle.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).