From: "Guillermo E. Martinez" <guillermo.e.martinez@oracle.com>
To: Dodji Seketeli <dodji@redhat.com>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH, request-for-review] Update CTF's ctf_dict_t detection
Date: Mon, 16 Jan 2023 10:35:53 -0600 [thread overview]
Message-ID: <20230116163553.wzkw34rsn7okz4xm@kamehouse> (raw)
In-Reply-To: <87mt6ivo7n.fsf@redhat.com>
On Mon, Jan 16, 2023 at 10:11:08AM +0100, Dodji Seketeli wrote:
> Hello,
>
> As ctf_dict_t can be an opaque type depending on the version of
> ctf-api.h, using AC_CHECK_TYPE won't work to detect it because that
> macro invokes sizeof(ctf_dict_t).
>
> With this change, we don't require that ctf_dict_t be fully defined.
>
> * configure.ac: Use AC_COMPILE_IFELSE to try and compile a code
> snippet that doesn't need that ctf_dict_t be fully defined.
>
> Would this be OK to commit?
It LGTM. I tested it, dependencies to enable CTF are detected by
`configure' script.
> Thanks.
>
Thanks!
> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
> ---
> configure.ac | 11 ++++++-----
> [...]
next prev parent reply other threads:[~2023-01-16 16:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-01-16 9:11 Dodji Seketeli
2023-01-16 16:35 ` Guillermo E. Martinez [this message]
2023-01-16 17:42 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230116163553.wzkw34rsn7okz4xm@kamehouse \
--to=guillermo.e.martinez@oracle.com \
--cc=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).