From: Dodji Seketeli <dodji@seketeli.org>
To: Sam James <sam@gentoo.org>
Cc: Sam James via Libabigail <libabigail@sourceware.org>
Subject: Re: [PATCH] configure.ac: add dist-xz
Date: Fri, 18 Nov 2022 13:10:46 +0100 [thread overview]
Message-ID: <87mt8ompix.fsf@seketeli.org> (raw)
In-Reply-To: <37661221-AC5A-42D1-B63B-8FC1184368EB@gentoo.org> (Sam James's message of "Thu, 17 Nov 2022 16:22:51 +0000")
Hello,
Sam James <sam@gentoo.org> a écrit:
[...]
> I've tweaked it to take TARBALL as both .gz and .xz, but tbh, I think
> we could very uncontroversially drop .gz too. A lot of software is .xz
> only (like all of GNOME) and it doesn't really bother anyone.
>
> My gut is it's not worth adding additional machinery to allow
> disabling xz creation because it kind of conflicts with the dist-*
> stuff from automake (I think we could do it, but it's a bit awkward).
>
> The gzip creation is pretty cheap though.
>
> The libabigail tarball is by necessity quite large (which was the
> motivation originally) so I think we have decent justification.
>
> TL;DR: I'll send a patch now with fixed TARBALL variable to include
> both .gz and .xz but not sure it's worth the complexity to
> allow specifically disabling either. If I had to choose, I'd just
> drop gzip entirely given other projects do that fine without problems.
OK, let's follow your gut feeling then :-) Your point of view seems
sensible to me. My initial inclination seems overkill.
I went ahead and applied your initial patch, in the form that I posted
at the end of my previous message, to master.
Thank you for your dedication.
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2022-11-18 12:10 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-11-08 7:35 Sam James
2022-11-08 8:04 ` Sam James
2022-11-17 10:39 ` Dodji Seketeli
2022-11-17 16:22 ` Sam James
2022-11-18 12:10 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mt8ompix.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=sam@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).