From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com, willdeacon@google.com
Subject: Re: [PATCH 2/2] symtab: fix up 64-bit ARM address which may contain tags
Date: Wed, 04 May 2022 12:05:42 +0200 [thread overview]
Message-ID: <87mtfxehop.fsf@seketeli.org> (raw)
In-Reply-To: <20220407162926.2076100-2-gprocida@google.com> (Giuliano Procida's message of "Thu, 7 Apr 2022 17:29:26 +0100")
Hello Giuliano,
Giuliano Procida <gprocida@google.com> a écrit:
> 64-bit ARM addresses normally have bits 47 to 63 as either all 0 or
> all 1. If tagging is used, bits 56 to 63 can vary, but the
> interpretation of such values is as if the bits were all the same as
> bit 55.
>
> Such tagging is used for HWASAN and this affects the ELF symbol values
> seen in shared libraries.
>
> This commit changes the interpretation of 64-bit ARM symbol values by
> unconditionally extending bit 55 into bits 56 to 63.
>
> This fixes missing types for symbols in HWASAN-compiled libraries.
>
> * src/abg-elf-helpers.cc: (architecture_is_arm64): Add helper.
> * src/abg-elf-helpers.h: Likewise.
> * src/abg-symtab-reader.cc: (get_symbol_value): Adjust 64-bit
> ARM symbol values by extending bit 55 into bits 56 to 63.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
next prev parent reply other threads:[~2022-05-04 10:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-04-07 16:29 [PATCH 1/2] symtab: refactor ELF symbol value tweaks Giuliano Procida
2022-04-07 16:29 ` [PATCH 2/2] symtab: fix up 64-bit ARM address which may contain tags Giuliano Procida
2022-05-04 10:05 ` Dodji Seketeli [this message]
2022-05-04 10:00 ` [PATCH 1/2] symtab: refactor ELF symbol value tweaks Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtfxehop.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=willdeacon@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).