From: Dodji Seketeli <dodji@redhat.com>
To: libabigail@sourceware.org
Subject: [PATCH, applied] reader: Canonicalizing a type once is enough
Date: Thu, 10 Jun 2021 11:19:43 +0200 [thread overview]
Message-ID: <87mtry2i1c.fsf@redhat.com> (raw)
Hello,
While looking at something else, I noticed that the abixml reader was
trying to canonicalize each type twice. Once should be enough.
* src/abg-reader.cc (build_type): Don't try to canonicalize the
type here because all the sub-routines of this function (which
actually build the type) already try to canonicalize it.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-reader.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/abg-reader.cc b/src/abg-reader.cc
index 6d25b690..c0385298 100644
--- a/src/abg-reader.cc
+++ b/src/abg-reader.cc
@@ -5698,7 +5698,6 @@ build_type(read_context& ctxt,
}
#endif
- ctxt.maybe_canonicalize_type(t);
return t;
}
--
2.30.0
--
Dodji
reply other threads:[~2021-06-10 9:19 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87mtry2i1c.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).