* [PATCH, applied] reader: Canonicalizing a type once is enough
@ 2021-06-10 9:19 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2021-06-10 9:19 UTC (permalink / raw)
To: libabigail
Hello,
While looking at something else, I noticed that the abixml reader was
trying to canonicalize each type twice. Once should be enough.
* src/abg-reader.cc (build_type): Don't try to canonicalize the
type here because all the sub-routines of this function (which
actually build the type) already try to canonicalize it.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-reader.cc | 1 -
1 file changed, 1 deletion(-)
diff --git a/src/abg-reader.cc b/src/abg-reader.cc
index 6d25b690..c0385298 100644
--- a/src/abg-reader.cc
+++ b/src/abg-reader.cc
@@ -5698,7 +5698,6 @@ build_type(read_context& ctxt,
}
#endif
- ctxt.maybe_canonicalize_type(t);
return t;
}
--
2.30.0
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-06-10 9:19 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-06-10 9:19 [PATCH, applied] reader: Canonicalizing a type once is enough Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).