* [PATCH, applied] writer: Fix control of emitting parm names in function types
@ 2024-05-06 16:41 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2024-05-06 16:41 UTC (permalink / raw)
To: libabigail
[-- Attachment #1: Type: text/plain, Size: 7987 bytes --]
Hello,
Emitting parameter names in function types should be controlled by the
set_write_parameter_names function. It turns out it is not. Fixed
thus and adjust testannotate and testreadwarf to avoid emitting
parameter names altogether. This removes some rare randomness in the
tests output.
* src/abg-writer.cc (write_function_type): Control emitting of
parameter names with the write_context::get_write_parameter_names
property.
* tests/test-annotate.cc (main): Do not emit function parameter
names.
* tests/test-read-dwarf.cc (main): Likewise.
* tests/data/test-annotate/libtest23.so.abi: Adjust.
* tests/data/test-annotate/libtest24-drop-fns-2.so.abi: Likewise.
* tests/data/test-annotate/libtest24-drop-fns.so.abi: Likewise.
* tests/data/test-annotate/test0.abi: Likewise.
* tests/data/test-annotate/test1.abi: Likewise.
* tests/data/test-annotate/test13-pr18894.so.abi: Likewise.
* tests/data/test-annotate/test14-pr18893.so.abi: Likewise.
* tests/data/test-annotate/test15-pr18892.so.abi: Likewise.
* tests/data/test-annotate/test17-pr19027.so.abi: Likewise.
* tests/data/test-annotate/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
Likewise.
* tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Likewise.
* tests/data/test-annotate/test2.so.abi: Likewise.
* tests/data/test-annotate/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Likewise.
* tests/data/test-annotate/test21-pr19092.so.abi: Likewise.
* tests/data/test-annotate/test4.so.abi: Likewise.
* tests/data/test-annotate/test6.so.abi: Likewise.
* tests/data/test-annotate/test8-qualified-this-pointer.so.abi:
Likewise.
* tests/data/test-read-dwarf/PR22015-libboost_iostreams.so.abi:
Likewise.
* tests/data/test-read-dwarf/PR22122-libftdc.so.abi: Likewise.
* tests/data/test-read-dwarf/PR24378-fn-is-not-scope.abi:
Likewise.
* tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Likewise.
* tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
Likewise.
* tests/data/test-read-dwarf/PR26261/PR26261-exe.abi: Likewise.
* tests/data/test-read-dwarf/PR27700/test-PR27700.abi: Likewise.
* tests/data/test-read-dwarf/libtest23.so.abi: Likewise.
* tests/data/test-read-dwarf/libtest24-drop-fns-2.so.abi:
Likewise.
* tests/data/test-read-dwarf/libtest24-drop-fns.so.abi: Likewise.
* tests/data/test-read-dwarf/test-PR26568-1.o.abi: Likewise.
* tests/data/test-read-dwarf/test-PR26568-2.o.abi: Likewise.
* tests/data/test-read-dwarf/test-libaaudio.so.abi: Likewise.
* tests/data/test-read-dwarf/test-libandroid.so.abi: Likewise.
* tests/data/test-read-dwarf/test0.abi: Likewise.
* tests/data/test-read-dwarf/test0.hash.abi: Likewise.
* tests/data/test-read-dwarf/test1.abi: Likewise.
* tests/data/test-read-dwarf/test1.hash.abi: Likewise.
* tests/data/test-read-dwarf/test10-pr18818-gcc.so.abi: Likewise.
* tests/data/test-read-dwarf/test11-pr18828.so.abi: Likewise.
* tests/data/test-read-dwarf/test12-pr18844.so.abi: Likewise.
* tests/data/test-read-dwarf/test13-pr18894.so.abi: Likewise.
* tests/data/test-read-dwarf/test14-pr18893.so.abi: Likewise.
* tests/data/test-read-dwarf/test15-pr18892.so.abi: Likewise.
* tests/data/test-read-dwarf/test16-pr18904.so.abi: Likewise.
* tests/data/test-read-dwarf/test17-pr19027.so.abi: Likewise.
* tests/data/test-read-dwarf/test18-pr19037-libvtkRenderingLIC-6.1.so.abi:
Likewise.
* tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
Likewise.
* tests/data/test-read-dwarf/test2.so.abi: Likewise.
* tests/data/test-read-dwarf/test2.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test20-pr19025-libvtkParallelCore-6.1.so.abi:
Likewise.
* tests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise.
* tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
Likewise.
* tests/data/test-read-dwarf/test4.so.abi: Likewise.
* tests/data/test-read-dwarf/test4.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test6.so.abi: Likewise.
* tests/data/test-read-dwarf/test6.so.hash.abi: Likewise.
* tests/data/test-read-dwarf/test8-qualified-this-pointer.so.abi:
Likewise.
* tests/data/test-read-dwarf/test8-qualified-this-pointer.so.hash.abi:
Likewise.
* tests/data/test-read-dwarf/test9-pr18818-clang.so.abi: Likewise.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to the master branch.
---
src/abg-writer.cc | 2 +-
tests/data/test-annotate/libtest23.so.abi | 6 +-
.../test-annotate/libtest24-drop-fns-2.so.abi | 10 +-
.../test-annotate/libtest24-drop-fns.so.abi | 10 +-
tests/data/test-annotate/test0.abi | 12 +-
tests/data/test-annotate/test1.abi | 8 +-
.../data/test-annotate/test13-pr18894.so.abi | 920 +-
.../data/test-annotate/test14-pr18893.so.abi | 448 +-
.../data/test-annotate/test15-pr18892.so.abi | 7562 +++++++--------
.../data/test-annotate/test17-pr19027.so.abi | 1256 +--
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 3870 ++++----
...19-pr19023-libtcmalloc_and_profiler.so.abi | 1698 ++--
tests/data/test-annotate/test2.so.abi | 4 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 1202 +--
.../data/test-annotate/test21-pr19092.so.abi | 1654 ++--
tests/data/test-annotate/test4.so.abi | 6 +-
tests/data/test-annotate/test6.so.abi | 2 +-
.../test8-qualified-this-pointer.so.abi | 2 +-
.../PR22015-libboost_iostreams.so.abi | 332 +-
.../test-read-dwarf/PR22122-libftdc.so.abi | 566 +-
.../PR24378-fn-is-not-scope.abi | 2 +-
.../data/test-read-dwarf/PR25007-sdhci.ko.abi | 136 +-
.../PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi | 386 +-
.../test-read-dwarf/PR26261/PR26261-exe.abi | 14 +-
.../test-read-dwarf/PR27700/test-PR27700.abi | 2 +-
tests/data/test-read-dwarf/libtest23.so.abi | 6 +-
.../libtest24-drop-fns-2.so.abi | 10 +-
.../test-read-dwarf/libtest24-drop-fns.so.abi | 10 +-
.../data/test-read-dwarf/test-PR26568-1.o.abi | 2 +-
.../data/test-read-dwarf/test-PR26568-2.o.abi | 2 +-
.../test-read-dwarf/test-libaaudio.so.abi | 184 +-
.../test-read-dwarf/test-libandroid.so.abi | 1110 +--
tests/data/test-read-dwarf/test0.abi | 12 +-
tests/data/test-read-dwarf/test0.hash.abi | 12 +-
tests/data/test-read-dwarf/test1.abi | 8 +-
tests/data/test-read-dwarf/test1.hash.abi | 8 +-
.../test-read-dwarf/test10-pr18818-gcc.so.abi | 968 +-
.../test-read-dwarf/test11-pr18828.so.abi | 1220 +--
.../test-read-dwarf/test12-pr18844.so.abi | 4464 ++++-----
.../test-read-dwarf/test13-pr18894.so.abi | 920 +-
.../test-read-dwarf/test14-pr18893.so.abi | 448 +-
.../test-read-dwarf/test15-pr18892.so.abi | 7562 +++++++--------
.../test-read-dwarf/test16-pr18904.so.abi | 4430 ++++-----
.../test-read-dwarf/test17-pr19027.so.abi | 1256 +--
...st18-pr19037-libvtkRenderingLIC-6.1.so.abi | 3870 ++++----
...19-pr19023-libtcmalloc_and_profiler.so.abi | 1698 ++--
tests/data/test-read-dwarf/test2.so.abi | 4 +-
tests/data/test-read-dwarf/test2.so.hash.abi | 4 +-
...st20-pr19025-libvtkParallelCore-6.1.so.abi | 1202 +--
.../test-read-dwarf/test21-pr19092.so.abi | 1654 ++--
.../test22-pr19097-libstdc++.so.6.0.17.so.abi | 8180 ++++++++---------
tests/data/test-read-dwarf/test4.so.abi | 6 +-
tests/data/test-read-dwarf/test4.so.hash.abi | 6 +-
tests/data/test-read-dwarf/test6.so.abi | 2 +-
tests/data/test-read-dwarf/test6.so.hash.abi | 2 +-
.../test8-qualified-this-pointer.so.abi | 2 +-
.../test8-qualified-this-pointer.so.hash.abi | 2 +-
.../test9-pr18818-clang.so.abi | 966 +-
tests/test-annotate.cc | 3 +-
tests/test-read-dwarf.cc | 2 +-
60 files changed, 30173 insertions(+), 30172 deletions(-)
The patch is too big for the mailing list so I am attaching it gzipped.
[-- Attachment #2: 0002-dwarf-reader-ir-Improve-detection-of-method-types-im.patch.gz --]
[-- Type: application/gzip, Size: 208268 bytes --]
[-- Attachment #3: Type: text/plain, Size: 14 bytes --]
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2024-05-06 16:42 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2024-05-06 16:41 [PATCH, applied] writer: Fix control of emitting parm names in function types Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).