public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@seketeli.org>
To: gprocida@google.com
Cc: libabigail@sourceware.org
Subject: [PATCH] comparison: Fix leaf report summary
Date: Wed, 01 Jun 2022 18:12:14 +0200	[thread overview]
Message-ID: <87o7zcs6qp.fsf@seketeli.org> (raw)

Hello Giuliano,

This patch is to address the problem reported at
https://sourceware.org/bugzilla/show_bug.cgi?id=29047 where the leaf
changes summary omits the number of (added/removed) ELF symbols that
have no debug info.

Fixed thus.

I'd be glad if you could tell me if this addresses the issue you are
seeing.

Thanks!

	* src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In
	the "leaf change summary" section, add the number of removed/added
	symbols not described by debug info.

Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
 src/abg-comparison.cc | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc
index 525605cb..2ce3f5d4 100644
--- a/src/abg-comparison.cc
+++ b/src/abg-comparison.cc
@@ -9858,7 +9858,11 @@ corpus_diff::priv::emit_diff_stats(const diff_stats&	s,
     s.net_num_vars_removed() +
     s.net_num_vars_added() +
     s.net_num_leaf_var_changes() +
-    s.net_num_leaf_type_changes();
+    s.net_num_leaf_type_changes() +
+    s.net_num_removed_func_syms() +
+    s.net_num_added_func_syms() +
+    s.net_num_removed_var_syms() +
+    s.net_num_added_var_syms();
 
   if (!sonames_equal_)
     out << indent << "ELF SONAME changed\n";
-- 
2.36.1


-- 
		Dodji

                 reply	other threads:[~2022-06-01 16:12 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87o7zcs6qp.fsf@seketeli.org \
    --to=dodji@seketeli.org \
    --cc=gprocida@google.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).