* [PATCH] comparison: Fix leaf report summary
@ 2022-06-01 16:12 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2022-06-01 16:12 UTC (permalink / raw)
To: gprocida; +Cc: libabigail
Hello Giuliano,
This patch is to address the problem reported at
https://sourceware.org/bugzilla/show_bug.cgi?id=29047 where the leaf
changes summary omits the number of (added/removed) ELF symbols that
have no debug info.
Fixed thus.
I'd be glad if you could tell me if this addresses the issue you are
seeing.
Thanks!
* src/abg-comparison.cc (corpus_diff::priv::emit_diff_stats): In
the "leaf change summary" section, add the number of removed/added
symbols not described by debug info.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
src/abg-comparison.cc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/abg-comparison.cc b/src/abg-comparison.cc
index 525605cb..2ce3f5d4 100644
--- a/src/abg-comparison.cc
+++ b/src/abg-comparison.cc
@@ -9858,7 +9858,11 @@ corpus_diff::priv::emit_diff_stats(const diff_stats& s,
s.net_num_vars_removed() +
s.net_num_vars_added() +
s.net_num_leaf_var_changes() +
- s.net_num_leaf_type_changes();
+ s.net_num_leaf_type_changes() +
+ s.net_num_removed_func_syms() +
+ s.net_num_added_func_syms() +
+ s.net_num_removed_var_syms() +
+ s.net_num_added_var_syms();
if (!sonames_equal_)
out << indent << "ELF SONAME changed\n";
--
2.36.1
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2022-06-01 16:12 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-06-01 16:12 [PATCH] comparison: Fix leaf report summary Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).