* [PATCH, applied] RHBZ1944096 - assertion failure during self comparison of systemd
@ 2021-09-08 14:19 Dodji Seketeli
0 siblings, 0 replies; only message in thread
From: Dodji Seketeli @ 2021-09-08 14:19 UTC (permalink / raw)
To: libabigail
Hello,
When reading the abixml representing an enumerator which value is
exactly either LLONG_MIN or LLONG_MAX, build_enum_type_decl fails
because we wrongly think that an underflow or overflow happened, while
using strtoll.
This patch fixes the condition used to detect {under,over}flow
whenusing strtoll.
* src/abg-reader.cc (build_enum_type_decl): When strtoll detects
an underflow or overflo, it sets errno to ERANGE. So take that
into account.
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
Applied to master.
---
src/abg-reader.cc | 6 +++++-
1 file changed, 5 insertions(+), 1 deletion(-)
diff --git a/src/abg-reader.cc b/src/abg-reader.cc
index f4fe4ce8..559f8210 100644
--- a/src/abg-reader.cc
+++ b/src/abg-reader.cc
@@ -4325,7 +4325,11 @@ build_enum_type_decl(read_context& ctxt,
if (a)
{
value = strtoll(CHAR_STR(a), NULL, 0);
- if (value == LLONG_MIN || value == LLONG_MAX)
+ // when strtoll encounters overflow or underflow, errno
+ // is set to ERANGE and the returned value is either
+ // LLONG_MIN or LLONG_MAX.
+ if ((errno == ERANGE)
+ && (value == LLONG_MIN || value == LLONG_MAX))
return nil;
}
--
2.30.0
--
Dodji
^ permalink raw reply [flat|nested] only message in thread
only message in thread, other threads:[~2021-09-08 14:20 UTC | newest]
Thread overview: (only message) (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2021-09-08 14:19 [PATCH, applied] RHBZ1944096 - assertion failure during self comparison of systemd Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).