Re: [PATCH] abipkgdiff: Fix comparing CTF kABIs using Oracle Linux RPMs

[Dodji Seketeli <dodji@seketeli.org>]

Hello Guillermo,

"Guillermo E. Martinez via Libabigail" <libabigail@sourceware.org> a
écrit:

> Hello,
>
> This patch is meant to fix how `abipkgdiff' using CTF origin is looking
> for dependencies to analyze kABIs. IMHO `file_is_kernel_package'
> function is relying on package name, so when `--ctf' is provided, it only
> will work with executables under uncompressed directories and it never
> will try to find `vmlinux.cfa' because it is just needed by KABIs. I
> think that an option to force handle a packages as kernel would be nice
> regardless the package name.
>
> Please let me know your comments,
> Thanks in advanced!,

Ahh, okay, I see.  Actually, I think the initial way in which
file_is_kernel_package detects that a package is a kernel package is
sub-optimal.  Rather than looking at the name of the package, I think it
should instead look for the 'vmlinuz' binary file inside the package.

I will soon post a patch that amends yours by fixing that initial issue
and adds the vmlinux.ctfa related fix to it.

[...]

Thanks for looking into this.

Cheers,

-- 
		Dodji