Re: [PATCH] Fix trivial typo when printing version string

[Dodji Seketeli <dodji@seketeli.org>]

Ben Woodard via Libabigail <libabigail@sourceware.org> a écrit:

> When abicompat prints its version string, it does not terminate
> it with a newline the way that other commands do. Contributed by
> Bolo.
>
> Signed-off-by: Ben Woodard <woodard@redhat.com>

Thanks for this patch!

I have just added a ChangeLog-compatible part to this commit log, as
stated in the COMMIT-LOG-GUIDELINES file at
https://sourceware.org/git/?p=libabigail.git;a=blob;f=COMMIT-LOG-GUIDELINES.

Below is the patch that was applied.

Thanks!

From 519d7ce8e5773099fbfa0515d00397c008a72327 Mon Sep 17 00:00:00 2001
From: Ben Woodard via Libabigail <libabigail@sourceware.org>
Date: Wed, 9 Jun 2021 14:50:12 -0700
Subject: [PATCH] Fix trivial typo when printing version string

When abicompat prints its version string, it does not terminate
it with a newline the way that other commands do. Contributed by
Bolo.

	* tools/abicompat.cc (main): Add a newline after version string.

Signed-off-by: Ben Woodard <woodard@redhat.com>
Signed-off-by: Dodji Seketeli <dodji@redhat.com>
---
 tools/abicompat.cc | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tools/abicompat.cc b/tools/abicompat.cc
index f9b019fb..be3946e1 100644
--- a/tools/abicompat.cc
+++ b/tools/abicompat.cc
@@ -633,7 +633,8 @@ main(int argc, char* argv[])
   if (opts.display_version)
     {
       emit_prefix(argv[0], cout)
-	<< abigail::tools_utils::get_library_version_string();
+	<< abigail::tools_utils::get_library_version_string()
+	<< "\n";
       return 0;
     }
 
-- 
2.30.0


Cheers,

-- 
		Dodji