public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Dodji Seketeli <dodji@redhat.com>
To: Giuliano Procida <gprocida@google.com>
Cc: Dodji Seketeli <dodji@redhat.com>,
	 woodard@redhat.com, guillermo.e.martinez@oracle.com,
	 jose.marchesi@oracle.com, libabigail@sourceware.org
Subject: Re: [PATCH 1/2] Use environment by reference
Date: Thu, 17 Nov 2022 16:35:49 +0100	[thread overview]
Message-ID: <87v8ndmw4q.fsf@redhat.com> (raw)
In-Reply-To: <CAGvU0HmNGrwjcMHzwCh8frfQRxGUWXKDBqz3dT_KpjvCoSs0MA@mail.gmail.com> (Giuliano Procida's message of "Thu, 17 Nov 2022 14:17:42 +0000")

Hello,

Giuliano Procida <gprocida@google.com> writes:

[...]


>> @@ -1358,7 +1358,7 @@ lookup_symbol_from_elf_hash_tab(const environment*                env,
>>  ///
>>  /// @return true iff the symbol was found.
>>  static bool
>
> You're losing the const in the next few functions. There may be some
> other similar cases.

Oh, good catch.  I have fixed those occurences, thanks!

> Otherwise, this looks like good to me.

Thanks, I have updated the branch for now.

Cheers,

[...]

-- 
		Dodji


  reply	other threads:[~2022-11-17 15:36 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-11-16 17:19 [PATCH 0/2, v2] Make front-ends be first class in the libabigail framework Dodji Seketeli
2022-11-16 17:28 ` [PATCH 1/2] Use environment by reference Dodji Seketeli
2022-11-17 14:17   ` Giuliano Procida
2022-11-17 15:35     ` Dodji Seketeli [this message]
2022-11-16 17:29 ` [PATCH 2/2] Make Front Ends first class citizens Dodji Seketeli
2022-11-18 17:19 ` [PATCH 0/2, v2] Make front-ends be first class in the libabigail framework Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87v8ndmw4q.fsf@redhat.com \
    --to=dodji@redhat.com \
    --cc=gprocida@google.com \
    --cc=guillermo.e.martinez@oracle.com \
    --cc=jose.marchesi@oracle.com \
    --cc=libabigail@sourceware.org \
    --cc=woodard@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).