From: Dodji Seketeli <dodji@redhat.com>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org
Subject: Re: [PATCH 2/2] Bug 26646 - unexpected declaration-only types
Date: Tue, 08 Feb 2022 11:27:58 +0100 [thread overview]
Message-ID: <87v8xplkk1.fsf@redhat.com> (raw)
In-Reply-To: <CAGvU0H=UV0FxvzqhQWRjU6F7_yRMxhEK5P_t3NKMAD02e55rpw@mail.gmail.com> (Giuliano Procida's message of "Mon, 7 Feb 2022 16:26:34 +0000")
Giuliano Procida <gprocida@google.com> writes:
> This looks good to me.
Thanks!
>
> In the case of the two kernel ABIs, it eliminates one of the two
> differences in declaration-only status. I'll follow up on the other
> difference in the bug when I have a bit more information to share.
Good to know, thank you.
[...]
>>
>> * src/abg-dwarf-reader.cc (add_or_update_class_type): Do not reuse
>> the IR for a DIE with the same textual representation as the one
>> we are seeing now.
>> * tests/data/test-annotate/test21-pr19092.so.abi: Adjust.
>> * tests/data/test-read-dwarf/test21-pr19092.so.abi: Likewise.
>>
>> Signed-off-by: Dodji Seketeli <dodji@redhat.com>
>
> Reviewed-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
[...]
>
> Cheers!
>
Cheers!
--
Dodji
prev parent reply other threads:[~2022-02-08 10:28 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-07 11:04 Patch review request for Bug 2664 " Dodji Seketeli
2022-02-07 11:09 ` [PATCH 1/2] symtab-reader: Remove an over-agressive assertion Dodji Seketeli
2022-02-07 15:33 ` Giuliano Procida
2022-02-07 16:49 ` Dodji Seketeli
2022-02-07 11:11 ` [PATCH 2/2] Bug 26646 - unexpected declaration-only types Dodji Seketeli
[not found] ` <CAGvU0H=UV0FxvzqhQWRjU6F7_yRMxhEK5P_t3NKMAD02e55rpw@mail.gmail.com>
2022-02-08 10:27 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87v8xplkk1.fsf@redhat.com \
--to=dodji@redhat.com \
--cc=gprocida@google.com \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).