From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com, mark@klomp.org
Subject: Re: [PATCH] DWARF reader: Interpret ARM32 ELF addresses correctly
Date: Wed, 10 Mar 2021 11:19:58 +0100 [thread overview]
Message-ID: <87wnufz4xd.fsf@seketeli.org> (raw)
In-Reply-To: <20210309225754.2759649-1-gprocida@google.com> (Giuliano Procida's message of "Tue, 9 Mar 2021 22:57:54 +0000")
Giuliano Procida <gprocida@google.com> a écrit:
> Bug 27552 - libabigail needs to interpret ARM32 symbol addresses specially
>
> The ARM32 ELF specification specifies that bit 0 of an ELF function
> address is a flag specifying whether the instructions are Thumb or
> ARM. So clear this bit before using the addresses for symbol mapping.
>
> * src/abg-dwarf-reader.cc
> (read_context::load_symbol_maps_from_symtab_section): Clear
> bit zero of ARM32 function addresses.
> * src/abg-elf-helpers.cc (architecture_is_arm32): Add new
> function.
> * src/abg-elf-helpers.h (architecture_is_arm32): Likewise.
> * tests/data/test-read-dwarf/test-libandroid.so.abi: Update.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master.
Thanks!
[...]
--
Dodji
prev parent reply other threads:[~2021-03-10 10:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-03-09 22:57 Giuliano Procida
2021-03-10 10:18 ` Matthias Maennich
2021-03-10 10:19 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87wnufz4xd.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).