From: Dodji Seketeli <dodji@seketeli.org>
To: gprocida at google dot com via Libabigail <libabigail@sourceware.org>
Cc: gprocida at google dot com <sourceware-bugzilla@sourceware.org>
Subject: Re: [Bug default/29239] New: abidiff - possibly unintentionally harmless diffs
Date: Mon, 13 Jun 2022 11:29:33 +0200 [thread overview]
Message-ID: <87y1y0kj2a.fsf@seketeli.org> (raw)
In-Reply-To: <bug-29239-9487@http.sourceware.org/bugzilla/> (gprocida at google dot com via Libabigail's message of "Fri, 10 Jun 2022 12:06:02 +0000")
gprocida at google dot com via Libabigail <libabigail@sourceware.org> a
écrit:
Hello,
> So struct foo has changed and the second half of struct boo has changed.
>
> abidiff treats 2 of the 6 changes as harmless. Is this intentional?
The two changes that are flagged harmless are these:
type of 'foo& lref1' changed:
referenced type 'struct foo' changed, as reported earlier
type of 'foo&& rref1' changed:
referenced type 'struct foo' changed, as reported earlier
They are actually "redundant" changes, meaning, the changes to struct
foo have already been reported earlier. So these changes are just being
left out of the report for "compactness", thus, hopefully, better
legibility.
So yes, that is intentional.
Cheers,
--
Dodji
next prev parent reply other threads:[~2022-06-13 9:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-06-10 12:06 gprocida at google dot com
2022-06-13 9:29 ` Dodji Seketeli [this message]
2022-06-13 9:29 ` [Bug default/29239] " dodji at seketeli dot org
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87y1y0kj2a.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=sourceware-bugzilla@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).