* [PATCH] test-annotate.cc: ignore whitespace during diff
@ 2022-05-30 7:55 Giuliano Procida
2022-05-30 10:11 ` Dodji Seketeli
0 siblings, 1 reply; 2+ messages in thread
From: Giuliano Procida @ 2022-05-30 7:55 UTC (permalink / raw)
To: libabigail; +Cc: dodji, kernel-team, gprocida, maennich, Bogdan Graur
The LLVM C++ demangler is being updated to remove the extra space
delimiter added between consecutive template closings. This change
ensures tests pass with both old and new versions.
* tests/test-annotate.cc (main): Pass diff -w option.
Suggested-by: Bogdan Graur <bgraur@google.com>
Signed-off-by: Giuliano Procida <gprocida@google.com>
---
tests/test-annotate.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/tests/test-annotate.cc b/tests/test-annotate.cc
index 174de483..750f5e88 100644
--- a/tests/test-annotate.cc
+++ b/tests/test-annotate.cc
@@ -173,7 +173,7 @@ main()
if (abidw_ok)
{
string diff_cmd =
- "diff -u " + ref_report_path + " " + out_report_path;
+ "diff -w -u " + ref_report_path + " " + out_report_path;
if (system(diff_cmd.c_str()))
is_ok &=false;
}
--
2.36.1.124.g0e6072fb45-goog
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH] test-annotate.cc: ignore whitespace during diff
2022-05-30 7:55 [PATCH] test-annotate.cc: ignore whitespace during diff Giuliano Procida
@ 2022-05-30 10:11 ` Dodji Seketeli
0 siblings, 0 replies; 2+ messages in thread
From: Dodji Seketeli @ 2022-05-30 10:11 UTC (permalink / raw)
To: Giuliano Procida; +Cc: libabigail, kernel-team, maennich, Bogdan Graur
Giuliano Procida <gprocida@google.com> a écrit:
> The LLVM C++ demangler is being updated to remove the extra space
> delimiter added between consecutive template closings. This change
> ensures tests pass with both old and new versions.
>
> * tests/test-annotate.cc (main): Pass diff -w option.
>
> Suggested-by: Bogdan Graur <bgraur@google.com>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2022-05-30 10:11 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2022-05-30 7:55 [PATCH] test-annotate.cc: ignore whitespace during diff Giuliano Procida
2022-05-30 10:11 ` Dodji Seketeli
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).