Re: [PATCH] DWARF reader: use size_t for DWARF expression length

[Giuliano Procida <gprocida@google.com>]

The latest merged commit doesn't have the extra fixes you mentioned.

I'm happy to replicate your work, but I risk leaving something out again.

Let me know,
Giuliano.

On Tue, 18 Jan 2022 at 09:52, Mark Wielaard <mark@klomp.org> wrote:
>
> Hi Giuliano,
>
> On Mon, Jan 17, 2022 at 02:51:15PM +0000, Giuliano Procida wrote:
> > A recent change broke 32-bit builds due to an implicit assumption that
> > size_t == uint64_t. This appears in the elfutils dwarf_getlocation*
> > functions' types.
> >
> > This commit updates callers and other functions to use size_t
> > consistently for such expression lengths and indexes.
> >
> >       * src/abg-dwarf-reader.cc (die_location_expr): Change expr_len
> >       argument type to size_t*.
> >       (op_manipulates_stack): Change expr_len and index argument
> >       types to size_t; change next_index argument type to size_t&.
> >       (eval_last_constant_dwarf_sub_expr): Change expr_len argument
> >       and local variables index and next_index types to size_t.
> >       (die_member_offset): Change local variable expr_len type to
> >       size_t.
> >       (die_location_address): Likewise.
> >       (die_virtual_function_index): Likewise.
>
> I also needed to change the len and index arguments of
> eval_last_constant_dwarf_sub_expr, op_pushes_constant_value,
> op_pushes_non_constant_value, op_is_arith_logic and
> op_is_control_flow.
>
> See attached.
>
> Cheers,
>
> Mark