From: Dodji Seketeli <dodji@seketeli.org>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, kernel-team@android.com,
maennich@google.com, mark@klomp.org
Subject: Re: [PATCH] DWARF reader: use size_t for DWARF expression length
Date: Tue, 18 Jan 2022 13:03:47 +0100 [thread overview]
Message-ID: <87fsplckt8.fsf@seketeli.org> (raw)
In-Reply-To: <20220117145115.659444-1-gprocida@google.com> (Giuliano Procida's message of "Mon, 17 Jan 2022 14:51:15 +0000")
Giuliano Procida <gprocida@google.com> a écrit:
> A recent change broke 32-bit builds due to an implicit assumption that
> size_t == uint64_t. This appears in the elfutils dwarf_getlocation*
> functions' types.
>
> This commit updates callers and other functions to use size_t
> consistently for such expression lengths and indexes.
>
> * src/abg-dwarf-reader.cc (die_location_expr): Change expr_len
> argument type to size_t*.
> (op_manipulates_stack): Change expr_len and index argument
> types to size_t; change next_index argument type to size_t&.
> (eval_last_constant_dwarf_sub_expr): Change expr_len argument
> and local variables index and next_index types to size_t.
> (die_member_offset): Change local variable expr_len type to
> size_t.
> (die_location_address): Likewise.
> (die_virtual_function_index): Likewise.
>
> Fixes: 16207c4af7bc ("Bug 28191 - Interpret DWARF 5 addrx locations")
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Applied to master, thanks!
[...]
Cheers,
--
Dodji
prev parent reply other threads:[~2022-01-18 12:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-01-17 14:51 Giuliano Procida
2022-01-18 9:52 ` Mark Wielaard
2022-01-18 9:57 ` Giuliano Procida
2022-01-18 12:03 ` Dodji Seketeli [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87fsplckt8.fsf@seketeli.org \
--to=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
--cc=mark@klomp.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).