Re: [PATCH] DWARF reader: Comment ARM32 ELF address interpretation

[Giuliano Procida <gprocida@google.com>]

Hi.

On Thu, 11 Mar 2021 at 17:16, Mark Wielaard <mark@klomp.org> wrote:

> Hi,
>
> On Wed, 2021-03-10 at 12:22 +0000, Giuliano Procida wrote:
> > Bug 27552 - libabigail needs to interpret ARM32 symbol addresses
> > specially
>
> BTW. I tried to get this correct for elfutils when using the libdwfl
> dwfl_module_addrsym and dwfl_module_addrinfo functions:
> https://sourceware.org/bugzilla/show_bug.cgi?id=27564
> Has a proposed patch that needs a bit more testing (and maybe a tweak).
>
>
Having a library layer that does all the fixups seems a lot better than
having the logic in libabigail.


> libabigail doesn't use these functions, but one benefit of them is that
> they also handle the case of ppc function descriptors (that is old
> style ppc32 and ppc64be).
>
>
Hopefully, they are relatively straightforward to drop in. However,
Matthias has symbol table reader changes still queued up; once these are
done, we can take a look.

libabibgail would become dependent on libdwfl version >= X for correctness,
so we'd need to assert that at compile time.

Thanks,
Giuliano.


> Cheers,
>
> Mark
>