From: David Marchand <david.marchand@redhat.com>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, Dodji Seketeli <dodji@seketeli.org>,
kernel-team@android.com, maennich@google.com
Subject: Re: [PATCH v2] DWARF reader: fix bitfield offset calculations
Date: Thu, 15 Jul 2021 18:21:01 +0200 [thread overview]
Message-ID: <CAJFAV8xU_1wL99geLb5=LVDYNuBN6g7t-Q2FkmjojYEBjdjohQ@mail.gmail.com> (raw)
In-Reply-To: <20210710165232.3071638-1-gprocida@google.com>
On Sat, Jul 10, 2021 at 6:52 PM Giuliano Procida <gprocida@google.com> wrote:
>
> PR28060 - Invalid offset for bitfields
>
> Bitfield and other member offsets can be specified in DWARF using:
>
> - DW_AT_data_bit_offset, or
> - DW_AT_data_member_location and optionally DW_AT_bit_offset.
>
> The code would only use the value DW_AT_data_member_location if there
> was no DW_AT_bit_offset. This commit fixes this and adjusts
> documentation and affected tests.
>
> * src/abg-dwarf-reader.cc (read_and_convert_DW_at_bit_offset):
> Update documentation.
> (die_member_offset): Treat DW_AT_bit_offset as an optional
> adjustment to DW_AT_data_member_location.
> * tests/data/test-annotate/test13-pr18894.so.abi: Update.
> * tests/data/test-annotate/test15-pr18892.so.abi: Update.
> * tests/data/test-annotate/test17-pr19027.so.abi: Update.
> * tests/data/test-annotate/test19-pr19023-libtcmalloc_and_profiler.so.abi:
> Update.
> * tests/data/test-annotate/test21-pr19092.so.abi: Update.
> * tests/data/test-diff-dwarf-abixml/PR25409-librte_bus_dpaa.so.20.0.abi:
> Regenerate.
> * tests/data/test-diff-pkg/libcdio-0.94-1.fc26.x86_64--libcdio-0.94-2.fc26.x86_64-report.1.txt:
> Report now empty.
> * tests/data/test-read-dwarf/PR25007-sdhci.ko.abi: Update.
> * tests/data/test-read-dwarf/PR25042-libgdbm-clang-dwarf5.so.6.0.0.abi:
> Update.
> * tests/data/test-read-dwarf/test13-pr18894.so.abi: Update.
> * tests/data/test-read-dwarf/test15-pr18892.so.abi: Update.
> * tests/data/test-read-dwarf/test17-pr19027.so.abi: Update.
> * tests/data/test-read-dwarf/test19-pr19023-libtcmalloc_and_profiler.so.abi:
> Update.
> * tests/data/test-read-dwarf/test21-pr19092.so.abi: Update.
> * tests/data/test-read-dwarf/test22-pr19097-libstdc++.so.6.0.17.so.abi:
> Update.
>
> Signed-off-by: Giuliano Procida <gprocida@google.com>
Forgot to send:
Tested-by: David Marchand <david.marchand@redhat.com>
Thanks for the fix.
--
David Marchand
next prev parent reply other threads:[~2021-07-15 16:21 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-07-09 23:16 [PATCH 0/1] Fix Bug 28060 - Invalid offset for bitfields Giuliano Procida
2021-07-09 23:16 ` [PATCH 1/1] DWARF reader: fix bitfield offset calculations Giuliano Procida
2021-07-10 9:18 ` David Marchand
2021-07-10 16:51 ` Giuliano Procida
2021-07-10 19:15 ` David Marchand
2021-07-10 16:52 ` [PATCH v2] " Giuliano Procida
2021-07-15 16:21 ` David Marchand [this message]
2021-07-19 11:59 ` [PATCH v2, applied] " Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAJFAV8xU_1wL99geLb5=LVDYNuBN6g7t-Q2FkmjojYEBjdjohQ@mail.gmail.com' \
--to=david.marchand@redhat.com \
--cc=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).