Patch for Incorrect Symbol DW_LANG_PL1 -> DW_LANG_PLI

["Sochat, Vanessa" <sochat1@llnl.gov>]

[-- Attachment #1: Type: text/plain, Size: 1555 bytes --]

Hi Libabigail (and master Dodji!),

A symbol in elfutils was renamed (see line 7 here) in elfutils:

https://chromium.googlesource.com/external/elfutils/+/515dd0acc77673c953380bcf5ccfb05b83c5a3ab/NEWS

This results in this error when trying to install the 2.0 libabigail release (and I suspect others depending on the version of elfutils used):
error: 'DW_LANG_PL1' was not declared in this scope; did you mean 'DW_LANG_PLI'

And after some poking I figured out that this line https://sourceware.org/git/?p=libabigail.git;a=blob;f=src/abg-dwarf-reader.cc;h=1d6ad24cbfcc2d94c07311bb04112f14f4f0e71c;hb=HEAD#l11056 needs to be DW_LANG_PLI instead of DW_LANG_PL1.

I am attaching the patch I used to make the fix in spack: https://github.com/spack/spack/blob/03f84fb440770101816dad61ca59cf1bebf1997b/var/spack/repos/builtin/packages/libabigail/package.py#L37
If you want to reproduce that bug, you should be able to clone spack, comment out the line for the patch, add spack’s bin to the path, and then spack install libabigail.

I’ve also been having some trouble building libabigail from the git repository – the instructions in the sourceware docs don’t work completely, as I get a “syntax error near unexpected token ‘XML,’ and commenting out that line gets a bit further, but then errors missing library paths for libxml (which I’ve added). Do you have your release scripts you might share to reproduce what is in the release tarball?

Thank you, and thank you for all the recent work on libabigail!

Best,

Vanessa

[-- Attachment #2: 0001-plt.patch --]
[-- Type: application/octet-stream, Size: 838 bytes --]

From ba5e2b5dc9de106635c12ebe9260e2fc0212ff91 Mon Sep 17 00:00:00 2001
From: Vanessa Sochat <sochat1@llnl.gov>
Date: Fri, 15 Oct 2021 05:17:47 +0000
Subject: [PATCH] fixing incorrect symbol

Signed-off-by: @vsoch <vsoch@noreply.users.github.com>
---
 src/abg-dwarf-reader.cc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/src/abg-dwarf-reader.cc b/src/abg-dwarf-reader.cc
index 1d6ad24c..8dd86c5a 100644
--- a/src/abg-dwarf-reader.cc
+++ b/src/abg-dwarf-reader.cc
@@ -11053,7 +11053,7 @@ dwarf_language_to_tu_language(size_t l)
       return translation_unit::LANG_Ada95;
     case DW_LANG_Fortran95:
       return translation_unit::LANG_Fortran95;
-    case DW_LANG_PL1:
+    case DW_LANG_PLI:
       return translation_unit::LANG_PL1;
     case DW_LANG_ObjC:
       return translation_unit::LANG_ObjC;
-- 
2.17.1