From: Mark Wielaard <mark@klomp.org>
To: "Sochat, Vanessa" <sochat1@llnl.gov>
Cc: "libabigail@sourceware.org" <libabigail@sourceware.org>
Subject: Re: Patch for Incorrect Symbol DW_LANG_PL1 -> DW_LANG_PLI
Date: Mon, 18 Oct 2021 18:25:31 +0200 [thread overview]
Message-ID: <68dda582d8a4fd0d58ed355df45e6ceecc18a36f.camel@klomp.org> (raw)
In-Reply-To: <3FA78256-D980-42E6-87EE-F2CE00957B63@llnl.gov>
Hi Vanessa,
On Mon, 2021-10-18 at 15:27 +0000, Sochat, Vanessa wrote:
> I tried the gamut of versions from elfutils, down to 0.163 in spack:
>
> https://github.com/spack/spack/blob/30e8dd95b54bb60b0b696ec85fb7f9b71f5e79dc/var/spack/repos/builtin/packages/elfutils/package.py#L25
>
> And no luck.
In that case I suspect somehow the build isn't using the right dwarf.h
header. It might be the:
depends_on('libdwarf')
libabigail doesn't depend on libdwarf and libdwarf is not part of
elfutils. It does provide a dwarf.h header though, that might simply
not be compatible.
elfutils-devel install it in /usr/include/dwarf.h
while libdwarf-devel installs it in /usr/include/libdwarf/dwarf.h
So in theory they shouldn't conflict, unless the compiler has
/usr/include/libdwarf on the include path.
> Notably, when I originally added libabigail I didn't see this error:
> https://github.com/spack/spack/commit/ef9a607c4c3bd01d6bcf3141244fd29
> 41725e92f#diff-
> a8ac1d28334e9664af1280644c56095a1ba1160e5cc8b9ceec6ef8ec85491653 so
> my early conclusion was that something had changed about libabigail
> between the previous (1.8x and 2.0) releases. I simply couldn't get
> it working without this patch, regardless of the versions of elfutils
> or dwarf that I pinned.
Not saying the PL1/PLI confusion shouldn't be fixed (it is a really odd
typo), but it is somewhat curious nobody else has reported this issue.
Which is why I suspect that somehow your build is using the "wrong"
dwarf.h. Because all elfutils/libdw versions of dwarf.h do have
DW_LANG_PL1 defined. If you are picking up a non-elfutils/libdw dwarf.h
maybe that explains some of the other build issues too?
Cheers,
Mark
next prev parent reply other threads:[~2021-10-18 16:25 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-17 20:53 Sochat, Vanessa
2021-10-17 22:04 ` Mark Wielaard
2021-10-18 15:27 ` Sochat, Vanessa
2021-10-18 16:25 ` Mark Wielaard [this message]
2021-10-18 17:08 ` Sochat, Vanessa
2021-10-18 18:03 ` Ben Woodard
2021-10-18 20:38 ` Sochat, Vanessa
2021-10-19 10:58 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=68dda582d8a4fd0d58ed355df45e6ceecc18a36f.camel@klomp.org \
--to=mark@klomp.org \
--cc=libabigail@sourceware.org \
--cc=sochat1@llnl.gov \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).