public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: Matthias Maennich <maennich@google.com>
To: Giuliano Procida <gprocida@google.com>
Cc: libabigail@sourceware.org, dodji@seketeli.org, kernel-team@android.com
Subject: Re: [PATCH] abg-ir.h: add declaration of operator<< for elf_symbol::visibility
Date: Wed, 7 Jul 2021 13:47:42 +0100	[thread overview]
Message-ID: <YOWibmcKRAnoCNmk@google.com> (raw)
In-Reply-To: <20210707102222.725766-1-gprocida@google.com>

On Wed, Jul 07, 2021 at 11:22:22AM +0100, Giuliano Procida wrote:
>There is a formatted output operator for elf_symbol::visibility in
>abg-ir.cc. However, it had no visibile declaration and was not usable
>by library users. This commit adds the declaration.
>
>	* include/abg-ir.h (operator<<(elf_symbol::visibility): Add
>	declaration.
>
>Signed-off-by: Giuliano Procida <gprocida@google.com>

Reviewed-by: Matthias Maennich <maennich@google.com>

Cheers,
Matthias

>---
> include/abg-ir.h | 3 +++
> 1 file changed, 3 insertions(+)
>
>diff --git a/include/abg-ir.h b/include/abg-ir.h
>index da43727f..641ce514 100644
>--- a/include/abg-ir.h
>+++ b/include/abg-ir.h
>@@ -1107,6 +1107,9 @@ operator<<(std::ostream& o, elf_symbol::type t);
> std::ostream&
> operator<<(std::ostream& o, elf_symbol::binding t);
>
>+std::ostream&
>+operator<<(std::ostream& o, elf_symbol::visibility t);
>+
> bool
> string_to_elf_symbol_type(const string&, elf_symbol::type&);
>
>-- 
>2.32.0.93.g670b81a890-goog
>

  reply	other threads:[~2021-07-07 12:47 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-07 10:22 Giuliano Procida
2021-07-07 12:47 ` Matthias Maennich [this message]
2021-07-16 15:45   ` [PATCH, applied] " Dodji Seketeli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=YOWibmcKRAnoCNmk@google.com \
    --to=maennich@google.com \
    --cc=dodji@seketeli.org \
    --cc=gprocida@google.com \
    --cc=kernel-team@android.com \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).