From: Mark Wielaard <mark@klomp.org>
To: Dodji Seketeli <dodji@seketeli.org>
Cc: Giuliano Procida <gprocida@google.com>,
maennich@google.com, libabigail@sourceware.org,
kernel-team@android.com
Subject: Re: [PATCH v3] Bug 28191 - Interpret DWARF 5 addrx locations
Date: Tue, 23 Nov 2021 20:59:43 +0100 [thread overview]
Message-ID: <YZ1IL9HE6IequmcX@wildebeest.org> (raw)
In-Reply-To: <87ilwiu72o.fsf@seketeli.org>
Hi,
On Tue, Nov 23, 2021 at 06:15:27PM +0100, Dodji Seketeli wrote:
> It seems to me that we can also do away with the use of eval_last_constant_dwarf_sub_expr from
> die_member_offset. Would that work on your testing binaries?
>
> From what I am seeing, dwarf_getlocation_attr and dwarf_getlocation are
> present in elfutils 0.176 which is the oldest version that we need to
> support, so we should be able to ditch eval_last_constant_dwarf_sub_expr
> and its dependencies altogether.
I don't know the libabigail code too well, but
eval_last_constant_dwarf_sub_expr seem to be a partial Dwarf
Expression evaluator. elfutils libdw doesn't export one (it really
should though). So I think you still need that code when you get a
non-trivial location expression.
Cheers,
Mark
next prev parent reply other threads:[~2021-11-23 19:59 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-27 18:54 [PATCH] " Giuliano Procida
2021-08-27 18:57 ` [PATCH v2] Bug 28191 - " Giuliano Procida
2021-11-19 15:01 ` [PATCH v3] " Giuliano Procida
2021-11-23 17:15 ` Dodji Seketeli
2021-11-23 19:59 ` Mark Wielaard [this message]
2021-11-24 11:11 ` Giuliano Procida
2021-11-24 11:33 ` Giuliano Procida
2021-11-24 11:44 ` Giuliano Procida
2022-01-13 8:56 ` [PATCH v4] " Giuliano Procida
2022-01-17 13:06 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=YZ1IL9HE6IequmcX@wildebeest.org \
--to=mark@klomp.org \
--cc=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=kernel-team@android.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).