From: Trilok Soni <quic_tsoni@quicinc.com>
To: John Moon <quic_johmoo@quicinc.com>, <libabigail@sourceware.org>,
<dodji@seketeli.org>
Cc: Satya Durga Srinivasu Prabhala <quic_satyap@quicinc.com>
Subject: Re: abidiff improvements for kernel UAPI checker
Date: Sun, 16 Apr 2023 11:33:34 -0700 [thread overview]
Message-ID: <b6647eee-f5a9-5e6e-b52c-1bfd15dad262@quicinc.com> (raw)
In-Reply-To: <5363161d-8167-284e-e35d-9a8ef20adea9@quicinc.com>
On 4/10/2023 5:45 PM, John Moon wrote:
> Hi all,
>
> As you may be aware from the Linux kernel mailing list threads I've been
> CC'ing you on, we're in the process of upstreaming a shell script that
> uses abidiff to compare Linux kernel userspace APIs between revisions.
> Linux UAPIs are supposed to be stable forever, so we're trying to detect
> when a patch breaks a UAPI.
>
> If you haven't been following, the latest thread is here:
> https://lore.kernel.org/lkml/20230407203456.27141-1-quic_johmoo@quicinc.com/
>
> At a high level, we're taking the header file before/after the patch,
> building it in a dummy C file, then taking advantage of abidiff's
> "--non-reachable-types" argument to compare all the symbols.
>
> This method works great! However, there are a couple of classes of ABI
> differences that are detected but don't qualify as UAPI-breaking.
>
> By far the most common class of differences occur with enum expansions.
>
> For example, this change triggers finding:
> https://github.com/torvalds/linux/commit/622f1b2fae2eea28a80b04f130e3bb54227699f8#diff-a7f82b68b3459e13934c123bda4c3a9be20eadebe938a376e39a395e5ffa825a
Any inputs here from the libabigail mailing list here?
---Trilok Soni
next prev parent reply other threads:[~2023-04-16 18:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-04-11 0:45 John Moon
2023-04-16 18:33 ` Trilok Soni [this message]
2023-04-21 18:21 ` Dodji Seketeli
2023-04-21 20:03 ` Dodji Seketeli
2023-04-24 18:39 ` John Moon
2023-05-10 14:21 ` Dodji Seketeli
2023-05-23 19:59 ` John Moon
2023-07-05 16:52 ` John Moon
2023-10-05 13:44 ` Support suppressing data members inserted right before flexible array members (was Re: abidiff improvements for kernel UAPI checker) Dodji Seketeli
2023-07-10 10:55 ` abidiff improvements for kernel UAPI checker Dodji Seketeli
2023-09-22 11:39 ` Dodji Seketeli
2023-09-22 11:51 ` Dodji Seketeli
2023-09-22 18:28 ` John Moon
2023-09-22 20:02 ` John Moon
2023-09-26 8:38 ` Dodji Seketeli
2023-09-27 17:37 ` John Moon
2023-09-29 9:52 ` Dodji Seketeli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=b6647eee-f5a9-5e6e-b52c-1bfd15dad262@quicinc.com \
--to=quic_tsoni@quicinc.com \
--cc=dodji@seketeli.org \
--cc=libabigail@sourceware.org \
--cc=quic_johmoo@quicinc.com \
--cc=quic_satyap@quicinc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).