From: Mark Wielaard <mark@klomp.org>
To: Giuliano Procida <gprocida@google.com>
Cc: "Dodji Seketeli" <dodji@seketeli.org>,
libabigail@sourceware.org,
"Matthias Männich" <maennich@google.com>
Subject: Re: [PATCH] symtab-reader: Setup aliases before checking ppc64 opd function entries
Date: Tue, 17 May 2022 16:03:11 +0200 [thread overview]
Message-ID: <bf71fbc4c2d174c58a8174af3608dd8dc1b33331.camel@klomp.org> (raw)
In-Reply-To: <CAGvU0H=Jesd6AC+Avkjv4g_o7Kmc=t5ZV6VrRc94WqcMaBEFSw@mail.gmail.com>
On Tue, 2022-05-17 at 14:51 +0100, Giuliano Procida wrote:
> > > + if (symbol_sptr->is_function() && is_ppc64)
>
> IIRC, someone said that this should apply to PPC32 as well, perhaps
> you, Mark?
Yes, in theory both ppc32 and ppc64 use function descriptors (and both
are big endian). But I haven't seen a real ppc32 setup in years.
If you want to support that then it should be as simple as defining a
architecture_is_ppc32 which is precisely like architecture_is_ppc64
with s/EM_PPC64/EM_PPC/
Cheers,
Mark
next prev parent reply other threads:[~2022-05-17 14:03 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-05-16 9:43 Dodji Seketeli
2022-05-17 9:59 ` Mark Wielaard
2022-05-17 13:51 ` Giuliano Procida
2022-05-17 14:03 ` Mark Wielaard [this message]
2022-05-27 16:33 ` Dodji Seketeli
2022-05-27 23:05 ` Mark Wielaard
2022-05-30 8:44 ` Dodji Seketeli
-- strict thread matches above, loose matches on Subject: below --
2022-05-01 22:16 Mark Wielaard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bf71fbc4c2d174c58a8174af3608dd8dc1b33331.camel@klomp.org \
--to=mark@klomp.org \
--cc=dodji@seketeli.org \
--cc=gprocida@google.com \
--cc=libabigail@sourceware.org \
--cc=maennich@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).