[Bug default/21485] problems compiling with clang

[Bug default/21485] problems compiling with clang

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
Created attachment 10047
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10047&action=edit
address some of the problems

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] New: problems compiling with clang

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

            Bug ID: 21485
           Summary: problems compiling with clang
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

I tried compiling libabigail with clang from:

$ clang --version
clang version 3.9.1 (tags/RELEASE_391/final)
Target: x86_64-unknown-linux-gnu
Thread model: posix
InstalledDir: /usr/bin
$ rpm -q clang
clang-3.9.1-2.fc25.x86_64

and I ran into a bunch of compilation errors and warnings. At least some of
which appear to be valid concerns which should be cleaned up:

 $ export CXX=clang++
 $ export CC=clang
 $ ../configure --prefix=/tmp/test-llvm 
...
config.status: executing libtool commands
configure:
=====================================================================
        Libabigail: 1.0.rc7
=====================================================================

                Here is the configuration of the package:

    Prefix                                         : /tmp/test-llvm
    Source code location                           : ..
    C Compiler                                     : clang
    C++ Compiler                                   : clang++
    GCC visibility attribute supported             : yes

 OPTIONAL FEATURES:
    Enable zip archives                            : no
    Use a C++-11 compiler                          : no
    libdw has the dwarf_getalt function            : yes
    Enable rpm support in abipkgdiff               : yes
    Enable deb support in abipkgdiff               : no
    Enable GNU tar archive support in abipkgdiff   : yes
    Enable bash completion                         : no
    Enable fedabipkgdiff                           : no
    Enable running tests under Valgrind            : no
    Generate html apidoc                           : no
    Generate html manual                           : yes

$ make -j4 all
make -k -j4
make --no-print-directory all-recursive
Making all in include
make[2]: Nothing to be done for 'all'.
Making all in src
  CXX      abg-ir.lo
  CXX      abg-corpus.lo
  CXX      abg-comparison.lo
  CXX      abg-suppression.lo
In file included from ../../src/abg-suppression.cc:33:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:31:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:31:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-corpus.h:26:
/home/ben/Work/libabigail/build-llvl/../include/abg-ir.h:312:3: warning: 
      'abigail::ir::ir_traversable_base::traverse' hides overloaded virtual
      function [-Woverloaded-virtual]
  traverse(ir_node_visitor& v);
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-traverse.h:92:16: note: 
      hidden overloaded virtual function
      'abigail::ir::traversable_base::traverse' declared here: type mismatch at
      1st parameter ('abigail::ir::node_visitor_base &' vs
      'abigail::ir::ir_node_visitor &')
  virtual bool traverse(node_visitor_base& v);

 <snip>              ^

In file included from ../../src/abg-suppression.cc:33:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:31:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:31:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-corpus.h:26:
/home/ben/Work/libabigail/build-llvl/../include/abg-ir.h:2341:9: warning: class
      member cannot be redeclared [-Wredeclared-class-member]
  class parameter;
        ^
/home/ben/Work/libabigail/build-llvl/../include/abg-ir.h:2331:9: note: previous
      declaration is here
  class parameter;
        ^
 <snip>

/home/ben/Work/libabigail/build-llvl/../include/abg-ir.h:3202:3: warning: 
      'abigail::ir::class_or_union::insert_member_decl' hides overloaded
virtual
      function [-Woverloaded-virtual]
  insert_member_decl(decl_base_sptr member, declarations::iterator before);
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-ir.h:1309:3: note: hidden
      overloaded virtual function 'abigail::ir::scope_decl::insert_member_decl'
      declared here: type mismatch at 1st parameter ('const decl_base_sptr &'
      (aka 'const shared_ptr<abigail::ir::decl_base> &') vs 'decl_base_sptr'
      (aka 'shared_ptr<abigail::ir::decl_base>'))
  insert_member_decl(const decl_base_sptr& member,
  ^

 <snip>

In file included from ../../src/abg-suppression.cc:33:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:31:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:32:
/home/ben/Work/libabigail/build-llvl/../include/abg-diff-utils.h:186:3:
warning: 
      all paths through this function will call itself [-Winfinite-recursion]
  {
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-diff-utils.h:194:3:
warning: 
      all paths through this function will call itself [-Winfinite-recursion]
  {
  ^

 <snip> 

In file included from ../../src/abg-suppression.cc:33:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:31:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:302:1:
warning: 
      'diff_traversable_base' defined as a class here but previously declared
as
      a struct [-Wmismatched-tags]
class diff_traversable_base : public traversable_base
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:267:1: note: 
      did you mean class here?
struct diff_traversable_base;
^~~~~~
class

<snip>


In file included from ../../src/abg-suppression.cc:33:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:31:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: error: 
      friend declaration specifying a default argument must be a definition
  compute_diff(const corpus_sptr f,
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2164:1: error: 
      friend declaration specifying a default argument must be the only
      declaration
compute_diff(const corpus_sptr,
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: note: 
      previous declaration is here
  compute_diff(const corpus_sptr f,
  ^
In file included from ../../src/abg-suppression.cc:33:
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:59:1:
warning: 
      'filter_base' defined as a struct here but previously declared as a class
      [-Wmismatched-tags]
struct filter_base : public diff_node_visitor
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:48:1: note: 
      did you mean struct here?
class filter_base;
^~~~~
struct
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:46:1: note: 
      did you mean struct here?
class filter_base;
^~~~~
struct
In file included from ../../src/abg-comparison.cc:38:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-suppression.h:28:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: error: 
      friend declaration specifying a default argument must be a definition
  compute_diff(const corpus_sptr f,
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2164:1: error: 
      friend declaration specifying a default argument must be the only
      declaration
compute_diff(const corpus_sptr,
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: note: 
      previous declaration is here
  compute_diff(const corpus_sptr f,
  ^
In file included from ../../src/abg-ir.cc:49:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-tools-utils.h:28:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-suppression.h:28:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:32:
/home/ben/Work/libabigail/build-llvl/../include/abg-diff-utils.h:186:3:
warning: 
      all paths through this function will call itself [-Winfinite-recursion]
  {
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-diff-utils.h:194:3:
warning: 
      all paths through this function will call itself [-Winfinite-recursion]
  {
  ^
In file included from ../../src/abg-corpus.cc:39:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-reader.h:34:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-suppression.h:28:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:302:1:
warning: 
      'diff_traversable_base' defined as a class here but previously declared
as
      a struct [-Wmismatched-tags]
class diff_traversable_base : public traversable_base
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:267:1: note: 
      did you mean class here?
struct diff_traversable_base;
^~~~~~
class
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:306:3:
warning: 
      'abigail::comparison::diff_traversable_base::traverse' hides overloaded
      virtual function [-Woverloaded-virtual]
  traverse(diff_node_visitor& v);
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-traverse.h:92:16: note: 
      hidden overloaded virtual function
      'abigail::ir::traversable_base::traverse' declared here: type mismatch at
      1st parameter ('abigail::ir::node_visitor_base &' vs
      'abigail::comparison::diff_node_visitor &')
  virtual bool traverse(node_visitor_base& v);
               ^
In file included from ../../src/abg-comparison.cc:39:
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:59:1:
warning: 
      'filter_base' defined as a struct here but previously declared as a class
      [-Wmismatched-tags]
struct filter_base : public diff_node_visitor
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comp-filter.h:48:1: note: 
      did you mean struct here?
class filter_base;
^~~~~
struct
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:46:1: note: 
      did you mean struct here?
class filter_base;
^~~~~
struct
In file included from ../../src/abg-ir.cc:49:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-tools-utils.h:28:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-suppression.h:28:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:302:1:
warning: 
      'diff_traversable_base' defined as a class here but previously declared
as
      a struct [-Wmismatched-tags]
class diff_traversable_base : public traversable_base
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:267:1: note: 
      did you mean class here?
struct diff_traversable_base;
^~~~~~
class
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:306:3:
warning: 
      'abigail::comparison::diff_traversable_base::traverse' hides overloaded
      virtual function [-Woverloaded-virtual]
  traverse(diff_node_visitor& v);
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-traverse.h:92:16: note: 
      hidden overloaded virtual function
      'abigail::ir::traversable_base::traverse' declared here: type mismatch at
      1st parameter ('abigail::ir::node_visitor_base &' vs
      'abigail::comparison::diff_node_visitor &')
  virtual bool traverse(node_visitor_base& v);
               ^
In file included from ../../src/abg-corpus.cc:39:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-reader.h:34:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-suppression.h:28:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: error: 
      friend declaration specifying a default argument must be a definition
  compute_diff(const corpus_sptr f,
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2164:1: error: 
      friend declaration specifying a default argument must be the only
      declaration
compute_diff(const corpus_sptr,
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: note: 
      previous declaration is here
  compute_diff(const corpus_sptr f,
  ^
In file included from ../../src/abg-ir.cc:49:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-tools-utils.h:28:
In file included from
/home/ben/Work/libabigail/build-llvl/../include/abg-suppression.h:28:
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: error: 
      friend declaration specifying a default argument must be a definition
  compute_diff(const corpus_sptr f,
  ^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2164:1: error: 
      friend declaration specifying a default argument must be the only
      declaration
compute_diff(const corpus_sptr,
^
/home/ben/Work/libabigail/build-llvl/../include/abg-comparison.h:2155:3: note: 
      previous declaration is here
  compute_diff(const corpus_sptr f,
  ^
../../src/abg-corpus.cc:344:13: warning: using the result of an assignment as a
      condition without parentheses [-Wparentheses]
    if (sym = (*f)->get_symbol())
        ~~~~^~~~~~~~~~~~~~~~~~~~
../../src/abg-corpus.cc:344:13: note: place parentheses around the assignment
to
      silence this warning
    if (sym = (*f)->get_symbol())
            ^
        (                       )
../../src/abg-corpus.cc:344:13: note: use '==' to turn this assignment into an
      equality comparison
    if (sym = (*f)->get_symbol())
            ^
            ==
../../src/abg-corpus.cc:356:13: warning: using the result of an assignment as a
      condition without parentheses [-Wparentheses]
    if (sym = (*v)->get_symbol())
        ~~~~^~~~~~~~~~~~~~~~~~~~
../../src/abg-corpus.cc:356:13: note: place parentheses around the assignment
to
      silence this warning
    if (sym = (*v)->get_symbol())
            ^
        (                       )
../../src/abg-corpus.cc:356:13: note: use '==' to turn this assignment into an
      equality comparison
    if (sym = (*v)->get_symbol())
            ^
            ==
../../src/abg-comparison.cc:2290:17: warning: expression with side effects will
      be evaluated despite being used as an operand to 'typeid'
      [-Wpotentially-evaluated-expression]
  return typeid(*first.get()) != typeid(*second.get());
                ^
../../src/abg-comparison.cc:2290:41: warning: expression with side effects will
      be evaluated despite being used as an operand to 'typeid'
      [-Wpotentially-evaluated-expression]
  return typeid(*first.get()) != typeid(*second.get());
                                        ^
../../src/abg-suppression.cc:3042:11: warning: using the result of an
assignment
      as a condition without parentheses [-Wparentheses]
        if (parm = read_parameter_spec_from_string
            ~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
../../src/abg-suppression.cc:3042:11: note: place parentheses around the
      assignment to silence this warning
        if (parm = read_parameter_spec_from_string
                 ^
../../src/abg-suppression.cc:3042:11: note: use '==' to turn this assignment
      into an equality comparison
        if (parm = read_parameter_spec_from_string
                 ^
                 ==
10 warnings and 2 errors generated.
Makefile:562: recipe for target 'abg-corpus.lo' failed
make[2]: *** [abg-corpus.lo] Error 1

...

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #7 from dodji at redhat dot com ---
Comment on attachment 10047
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10047
address some of the problems

I have committed and pushed this to the master branch into commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=b8a629f4a18cd132a600e67677706a1f44cb8024.

I have amended the commit to remove the change that was undone by the next
patch.  I have also added a change log to it, to make it comply with the commit
log guidelines of the project at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=blob_plain;f=COMMIT-LOG-GUIDELINES

Thank you!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[jwakely.gcc at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

Jonathan Wakely <jwakely.gcc at gmail dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jwakely.gcc at gmail dot com

--- Comment #4 from Jonathan Wakely <jwakely.gcc at gmail dot com> ---
Surely this isn't right:

--- a/src/abg-comparison.cc     
+++ a/src/abg-comparison.cc     
@@ -2287,7 +2287,7 @@
distinct_diff::entities_are_of_distinct_kinds(type_or_decl_base_sptr first,
   if (first == second)
     return false;

-  return typeid(*first.get()) != typeid(*second.get());
+  return typeid( (*first.get()) != typeid((*second.get()));
 }

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #8 from dodji at redhat dot com ---
Comment on attachment 10048
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10048
fix a few more warnings

I have committed and pushed this patch to the master branch in commit
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=commit;h=3011d2ac8da21e2f7cba868ba43963e60c22f283

I have amended the patch to make it applied to the first patch that I have
amended as well.  I have also added a commit log to it, following the commit
log rules of the project, described at
https://sourceware.org/git/gitweb.cgi?p=libabigail.git;a=blob_plain;f=COMMIT-LOG-GUIDELINES

Thanks!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
Created attachment 10048
  --> https://sourceware.org/bugzilla/attachment.cgi?id=10048&action=edit
fix a few more warnings

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
I am uncertain on how to address the warnings about overloaded virtual
functions. I think that what you are doing is intentional and valid and the
warning may be spurious but I haven't come up with a way to address it.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #9 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #3)
> I am uncertain on how to address the warnings about overloaded virtual
> functions. I think that what you are doing is intentional and valid and the
> warning may be spurious but I haven't come up with a way to address it.


Right.  I'd say that warning is spurious in this case because the overloading
of the traverse member function was done on purpose.

Hopefully -Wno-overloaded-virtual should shut that warning down.


In any case, I have applied the patches you filed, thank you for those!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[jwakely.gcc at gmail dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #5 from Jonathan Wakely <jwakely.gcc at gmail dot com> ---
Ah, I see the second patch undoes that change.

IMHO -Wno-mismatched-tags should always be used with Clang, it's a silly
warning.

For most of the "condition without parentheses" I would simply change it to:

  d = func();
  if (d)
    ...

instead of adding parentheses.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

--- Comment #6 from Ben Woodard <woodard at redhat dot com> ---
I was unable to suppress the warning using -Wno-mismatched-tags 
I also tried:

export CXXFLAGS="-Wno-mismatched-tags -Wno-overloaded-virtual"
export CXXFLAGS="-Wno-mismatched-tags -Woverloaded-virtual"

None of that seemed to suppress those warnings.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/21485] problems compiling with clang

[maennich at android dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=21485

Matthias Maennich <maennich at android dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maennich at android dot com
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #10 from Matthias Maennich <maennich at android dot com> ---
Building with clang is now fully supported and warnings have been addressed.

-- 
You are receiving this mail because:
You are on the CC list for the bug.