[Bug default/25043] New: abidiff doesn't take stdin

[Bug default/25043] New: abidiff doesn't take stdin

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25043

            Bug ID: 25043
           Summary: abidiff doesn't take stdin
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

It would be nice if abidiff acceped - and used it as stdin.

abidw elf.file | abidiff - elf.file2

alternatively even accepting named pipes would be useful.

mknod foo p
abidw elf.file >foo &
abidiff foo elf.file2

unfornately that fails with:

foo is not a regular file
[ben@Mustang spack]$ echo $?
1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25043] abidiff doesn't take stdin

[maennich at android dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25043

Matthias Maennich <maennich at android dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |maennich at android dot com

--- Comment #1 from Matthias Maennich <maennich at android dot com> ---
Just as a comment:

 $ abidiff elf.file elf.file2

should do the trick for your particular case where you would extract xml
representations from single elf binaries. Just compare the binaries directly,
or binaries to xml files.

For the case where abidiff is not able to compare directly, e.g.

  $ abidiff <(abidw --linux-tree tree1/) <(abidw --linux-tree tree2/)

you suggestion could come in handy, but on the other hand side, it feels a bit
inconsistent that you can only pass one input via stdin and still have to
specify the other ...

So, this ends up being only useful for cases where abidiff does not handle
input directly yet:

 $ abidw --linux-tree tree1/ | abidiff - --linux-tree tree2/


But I would rather teach abidiff how to deal with two linux trees as it can
deal with all the other types (xml, binary) as an input already.

Did I miss a significant other case here?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25043] abidiff doesn't take stdin

[maennich at android dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25043

--- Comment #3 from Matthias Maennich <maennich at android dot com> ---
> This is what kmidiff is for (comparing two Linux *Kernel* trees), at the
> moment. FYI, kmi stands for Kernel Module Interface.

I know. Still I always feel like it is missing in abidiff :-)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25043] abidiff doesn't take stdin

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25043

--- Comment #2 from dodji at redhat dot com ---
"maennich at android dot com" <sourceware-bugzilla@sourceware.org>
writes:


> But I would rather teach abidiff how to deal with two linux trees as it can
> deal with all the other types (xml, binary) as an input already.

This is what kmidiff is for (comparing two Linux *Kernel* trees), at the
moment. FYI, kmi stands for Kernel Module Interface.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25043] abidiff doesn't take stdin

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25043

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
While ELF files and their DWARF are not streamable reading abixml is serialized
enough that it should be streamable. The real problem that this creates is when
preserving abixml files on storage in a compact format.

Say for example:
abidw foo.elf | gzip > foo.abixml.gz

Then later on you want to use it in a diff, then you run into a two step
process that requires extra temporary storage.

gunzip -c foo.abixml.gz > /tmp/foo.abixml
abidiff /tmp/foo.abixml
rm /tmp/foo.abixml

However if abidiff could handle stdin then it would be a much simpler process:
gunzip -c foo.abixml.gz | abidiff - newfoo.elf

-- 
You are receiving this mail because:
You are on the CC list for the bug.