[Bug default/25989] New: abg-ir: type_topo_comp doesn't meet irreflexive requirements

[Bug default/25989] New: abg-ir: type_topo_comp doesn't meet irreflexive requirements

[maennich at android dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25989

            Bug ID: 25989
           Summary: abg-ir: type_topo_comp doesn't meet irreflexive
                    requirements
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: maennich at android dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

When compiling and running abidw with G++ 9.2.1 as follows

 $ tools/abidw tests/data/test-read-dwarf/test1

  (simplified from the command run during tests/runtestannotate)

the following diagnostic is emitted:

In function:
    void std::sort(_RAIter, _RAIter, _Compare) [with _RAIter =
   
__gnu_debug::_Safe_iterator<__gnu_cxx::__normal_iterator<std::shared_ptr<abigail::ir::type_base>*,
    std::__cxx1998::vector<std::shared_ptr<abigail::ir::type_base>,
    std::allocator<std::shared_ptr<abigail::ir::type_base> > > >,
    std::__debug::vector<std::shared_ptr<abigail::ir::type_base> >,
    std::random_access_iterator_tag>; _Compare =
    abigail::ir::type_topo_comp]

Error: comparison doesn't meet irreflexive requirements, assert(!(a < a)).

Objects involved in the operation:
    instance "functor" @ 0x0x7fff8c9184ff {
      type = abigail::ir::type_topo_comp;
    }
    iterator::value_type "ordered type" {
      type = std::shared_ptr<abigail::ir::type_base>;
    }


This points to src/abg-ir.cc around line 2615.
Some discussion around this happened in the thread following
https://sourceware.org/pipermail/libabigail/2020q2/002192.html

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25989] abg-ir: type_topo_comp doesn't meet irreflexive requirements

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25989

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |ASSIGNED
   Last reconfirmed|                            |2020-05-19
     Ever confirmed|0                           |1

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25989] abg-ir: type_topo_comp doesn't meet irreflexive requirements

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25989

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #1 from dodji at redhat dot com ---
Thanks for taking the time to file this issue.

So, I can indeed reproduce the issue, when building with ABIGAIL_DEVEL=on set.

The issue should hopefully be fixed in the master branch by this commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=e8bf5b803c44d7ec40f9659295a5d9f1e3feefcb.

Thanks again and sorry for the inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.