[Bug default/25990] New: Segfault comparing RPMs with abipkgdiff

[Bug default/25990] New: Segfault comparing RPMs with abipkgdiff

[tstellar at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25990

            Bug ID: 25990
           Summary: Segfault comparing RPMs with abipkgdiff
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: tstellar at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

I'm getting a segfault when trying to compare the ABI of two RPMs using
abipkgdiff.  I'm using abipkgdiff v1.7.0.  To reproduce:

wget https://fedorapeople.org/~tstellar/abipkgdiff-inputs.tar.gz
tar -xzf abipkgdiff-inputs.tar.gz
cd abipkgdiff-inputs
abipkgdiff  --no-parallel --fail-no-dbg --verbose --debug-info-pkg1
lld-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm --debug-info-pkg2
lld-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm --debug-info-pkg1
lld-libs-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm --devel-pkg1
lld-devel-10.0.0-0.2.rc2.fc33.x86_64.rpm --debug-info-pkg2
clang/lld-libs-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm --devel-pkg2
clang/lld-devel-10.0.0-0.2.rc2.fc33.x86_64.rpm
lld-libs-10.0.0-0.2.rc2.fc33.x86_64.rpm
clang/lld-libs-10.0.0-0.2.rc2.fc33.x86_64.rpm

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25990] Segfault comparing RPMs with abipkgdiff

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25990

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25990] Segfault comparing RPMs with abipkgdiff

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25990

--- Comment #1 from dodji at redhat dot com ---
It looks like the problem comes from this part of the command line:

   --debug-info-pkg2 lld-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm

That part is saying that the package
lld-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm should be used as the debug info
for the package clang/lld-libs-10.0.0-0.2.rc2.fc33.x86_64.rpm.

I believe what is happening is that libabigail is using the debug info that was
provided even though it doesn't match the binary being analyzed.  That led to
an inconsistency down the road, that made us hit an assert.

I need to look into trying to detect that problem earlier and emit a proper
error message rather to assert and crash, I guess.

But for now, you can get going by using:

   --debug-info-pkg2 clang/lld-debuginfo-10.0.0-0.2.rc2.fc33.x86_64.rpm

Doing that seems to make it work for me.

You don't need the --no-parallel --verbose options, I believe.  Thinks are
faster without them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/25990] Segfault comparing RPMs with abipkgdiff

[tstellar at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=25990

--- Comment #2 from Tom Stellard <tstellar at redhat dot com> ---
If I drop the options specifying the lld-debuginfo*, I get error messages like
this:

abipkgdiff: Comparing the ABIs of file
/root/.cache/libabigail/abipkgdiff-tmp-dir-7p2Kvx/package1/usr/lib64/liblldELF.so.10
and
/root/.cache/libabigail/abipkgdiff-tmp-dir-7p2Kvx/package2/usr/lib64/liblldELF.so.10...
abipkgdiff:   Reading file
/root/.cache/libabigail/abipkgdiff-tmp-dir-7p2Kvx/package1/usr/lib64/liblldELF.so.10
...
abipkgdiff: Could not read file
'/root/.cache/libabigail/abipkgdiff-tmp-dir-7p2Kvx/package1/usr/lib64/liblldELF.so.10'
properly
abipkgdiff: while reading
file/root/.cache/libabigail/abipkgdiff-tmp-dir-7p2Kvx/package1/usr/lib64/liblldELF.so.10
abipkgdiff: Could not find alternate debug info file:
../../.dwz/lld-10.0.0-0.2.rc2.fc33.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.