public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/25998] Support incomplete enum types
Date: Tue, 19 May 2020 17:43:53 +0000	[thread overview]
Message-ID: <bug-25998-9487-aFBQSEWsY8@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-25998-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=25998

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
   Last reconfirmed|                            |2020-05-19
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1

--- Comment #1 from dodji at redhat dot com ---
Hello,

Thank you for filling this enhancement request and for working on its
underlying feature.

I agree with you that the incomplete enum support is needed and I am glad that
you started working on it.  I want to help get it in, so I am looking at it.

As for the way to go, I tend to not be a fan of early optimization.  So really,
at first, I wouldn't spend to much time (and I'd rather not spent too much
review time) on trying to remove duplicated code etc.

I'd rather want to have the feature in and make it work solidly first.  Of
course, if the design is elegant enough to integrate with the code base in a
manner that avoids duplication, then fine.  But I don't think we should go out
of our way to try and squeeze all the juice out of avoiding duplication.

Incidentally, I have posted a comment on the WIP types patches at
https://sourceware.org/pipermail/libabigail/2020q2/002262.html.

I'll be looking at the C++ enum type specification again, as I don't have the
details in mind at the moment.

Thanks again!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  reply	other threads:[~2020-05-19 17:43 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-15 18:19 [Bug default/25998] New: " gprocida+abigail at google dot com
2020-05-19 17:43 ` dodji at redhat dot com [this message]
2020-07-06 11:36 ` [Bug default/25998] " dodji at redhat dot com
2020-07-08 15:33 ` dodji at redhat dot com
2020-07-08 22:14 ` gprocida+abigail at google dot com
2020-07-09 13:20 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-25998-9487-aFBQSEWsY8@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).