From: "dodji at seketeli dot org" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26012] abidiff: do not emit qualified name for data members
Date: Mon, 08 Feb 2021 13:14:40 +0000 [thread overview]
Message-ID: <bug-26012-9487-Dv9PSebTTC@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26012-9487@http.sourceware.org/bugzilla/>
https://sourceware.org/bugzilla/show_bug.cgi?id=26012
--- Comment #3 from dodji at seketeli dot org ---
Hello,
gprocida+abigail at google dot com via Libabigail
<libabigail@sourceware.org> a écrit:
> https://sourceware.org/bugzilla/show_bug.cgi?id=26012
>
> Giuliano Procida <gprocida+abigail at google dot com> changed:
>
> What |Removed |Added
> ----------------------------------------------------------------------------
> CC| |gprocida+abigail at google dot com
>
> --- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> ---
> Dodji, how would you feel about an intermediate stage where the types are
> retained, but the redundant qualification is eliminated?
I like the idea!
> 'struct task_struct at sched.h:635:1' changed:
> type size hasn't changed
> 1 data member insertion:
> 'unsigned int in_ubsan', at offset 16704 (in bits) at sched.h:1006:1
> there are data member changes:
> 'void* journal_info' offset changed from 16704 to 16768 (in bits) (by +64
> bits)
> 'bio_list* bio_list' offset changed from 16768 to 16832 (in bits) (by +64
> bits)
> 'blk_plug* plug' offset changed from 16832 to 16896 (in bits) (by +64 bits)
> 'reclaim_state* reclaim_state' offset changed from 16896 to 16960 (in bits)
> (by +64 bits)
> 'backing_dev_info* backing_dev_info' offset changed from 16960 to 17024 (in
> bits) (by +64 bits)
> 'io_context* io_context' offset changed from 17024 to 17088 (in bits) (by
> +64 bits)
> 'capture_control* capture_control' offset changed from 17088 to 17152 (in
> bits) (by +64 bits)
> 'unsigned long int ptrace_message' offset changed from 17152 to 17216 (in
> bits) (by +64 bits)
> 'kernel_siginfo_t* last_siginfo' offset changed from 17216 to 17280 (in
> bits) (by +64 bits)
And I like the output as well. I think it's perfect.
Thanks.
Cheers,
--
You are receiving this mail because:
You are on the CC list for the bug.
next prev parent reply other threads:[~2021-02-08 13:14 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-18 20:04 [Bug default/26012] New: " maennich at android dot com
2021-01-26 13:14 ` [Bug default/26012] " gprocida+abigail at google dot com
2021-02-08 13:14 ` Dodji Seketeli
2021-02-03 17:53 ` gprocida+abigail at google dot com
2021-02-08 13:14 ` dodji at seketeli dot org [this message]
2021-02-09 10:47 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-26012-9487-Dv9PSebTTC@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).