Re: [Bug default/26012] abidiff: do not emit qualified name for data members

[Dodji Seketeli <dodji@seketeli.org>]

Hello,

gprocida+abigail at google dot com via Libabigail
<libabigail@sourceware.org> a écrit:

> https://sourceware.org/bugzilla/show_bug.cgi?id=26012
>
> Giuliano Procida <gprocida+abigail at google dot com> changed:
>
>            What    |Removed                     |Added
> ----------------------------------------------------------------------------
>                  CC|                            |gprocida+abigail at google dot com
>
> --- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> ---
> Dodji, how would you feel about an intermediate stage where the types are
> retained, but the redundant qualification is eliminated?

I like the idea!

> 'struct task_struct at sched.h:635:1' changed:
>   type size hasn't changed
>   1 data member insertion:
>     'unsigned int in_ubsan', at offset 16704 (in bits) at sched.h:1006:1
>   there are data member changes:
>     'void* journal_info' offset changed from 16704 to 16768 (in bits) (by +64
> bits)
>     'bio_list* bio_list' offset changed from 16768 to 16832 (in bits) (by +64
> bits)
>     'blk_plug* plug' offset changed from 16832 to 16896 (in bits) (by +64 bits)
>     'reclaim_state* reclaim_state' offset changed from 16896 to 16960 (in bits)
> (by +64 bits)
>     'backing_dev_info* backing_dev_info' offset changed from 16960 to 17024 (in
> bits) (by +64 bits)
>     'io_context* io_context' offset changed from 17024 to 17088 (in bits) (by
> +64 bits)
>     'capture_control* capture_control' offset changed from 17088 to 17152 (in
> bits) (by +64 bits)
>     'unsigned long int ptrace_message' offset changed from 17152 to 17216 (in
> bits) (by +64 bits)
>     'kernel_siginfo_t* last_siginfo' offset changed from 17216 to 17280 (in
> bits) (by +64 bits)

And I like the output as well.  I think it's perfect.

Thanks.

Cheers,

-- 
		Dodji