[Bug default/26146] New: No type information for ARM thumb object files

[Bug default/26146] New: No type information for ARM thumb object files

[sourceware at rahix dot de]

https://sourceware.org/bugzilla/show_bug.cgi?id=26146

            Bug ID: 26146
           Summary: No type information for ARM thumb object files
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: sourceware at rahix dot de
                CC: libabigail at sourceware dot org
  Target Milestone: ---

Created attachment 12630
  --> https://sourceware.org/bugzilla/attachment.cgi?id=12630&action=edit
ARM thumb object file for reproduction

It looks like libabigail fails to extract type information from ARM thumb
object files.

Compiling a test file using 'arm-none-eabi-gcc -g' produces an object file
that libabigail can extract type information from, but 'arm-none-eabi-gcc
-g -mthumb' does not.  The object file does contain debug symbols as I can
see with `eu-readelf --debug-dump=info`.

Using `abidw` I just get this:

    <abi-corpus path='thumb.o' architecture='elf-arm'>
      <elf-function-symbols>
        <!-- func_a -->
        <elf-symbol name='func_a' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
        <!-- func_b -->
        <elf-symbol name='func_b' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
      </elf-function-symbols>
    </abi-corpus>

The source for the test file was:

    int func_a(char *buf, unsigned char len)
    {
            return -1;
    }

    char *func_b(char *ptr, void *ptr2)
    {
            return NULL;
    }

I've attached the object file.

Regards,
Rahix

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26146] No type information for ARM thumb object files

[gprocida+abigail at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26146

Giuliano Procida <gprocida+abigail at google dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gprocida+abigail at google dot com

--- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> ---
Hi.

This looks like it was fixed with
https://sourceware.org/git/?p=libabigail.git;a=commit;h=32c7829e4156666e1975329fb1b3201c43b5f84f.

$ abidw thumb.o 
<abi-corpus version='2.0' path='thumb.o' architecture='elf-arm'>
  <elf-function-symbols>
    <elf-symbol name='func_a' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
    <elf-symbol name='func_b' type='func-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
  </elf-function-symbols>
  <abi-instr address-size='32' path='foo.c'
comp-dir-path='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb'
language='LANG_C99'>
    <type-decl name='char' size-in-bits='8' id='type-id-1'/>
    <type-decl name='int' size-in-bits='32' id='type-id-2'/>
    <type-decl name='unsigned char' size-in-bits='8' id='type-id-3'/>
    <type-decl name='void' id='type-id-4'/>
    <pointer-type-def type-id='type-id-1' size-in-bits='32' id='type-id-5'/>
    <pointer-type-def type-id='type-id-4' size-in-bits='32' id='type-id-6'/>
    <function-decl name='func_b' mangled-name='func_b'
filepath='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb/foo.c'
line='8' column='1' visibility='default' binding='global' size-in-bits='32'
elf-symbol-id='func_b'>
      <parameter type-id='type-id-5' name='ptr'
filepath='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb/foo.c'
line='8' column='1'/>
      <parameter type-id='type-id-6' name='ptr2'
filepath='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb/foo.c'
line='8' column='1'/>
      <return type-id='type-id-5'/>
    </function-decl>
    <function-decl name='func_a' mangled-name='func_a'
filepath='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb/foo.c'
line='3' column='1' visibility='default' binding='global' size-in-bits='32'
elf-symbol-id='func_a'>
      <parameter type-id='type-id-5' name='buf'
filepath='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb/foo.c'
line='3' column='1'/>
      <parameter type-id='type-id-3' name='len'
filepath='/home/rahix/Documents/Development/Experiments/libabigail/test-thumb/foo.c'
line='3' column='1'/>
      <return type-id='type-id-2'/>
    </function-decl>
  </abi-instr>
</abi-corpus>

Please can you check everything is as expected now?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26146] No type information for ARM thumb object files

[sourceware at rahix dot de]

https://sourceware.org/bugzilla/show_bug.cgi?id=26146

Rahix <sourceware at rahix dot de> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|UNCONFIRMED                 |RESOLVED

--- Comment #2 from Rahix <sourceware at rahix dot de> ---
Hello,

yes, I just retried with the latest version and everything seems to work now. 
Thanks a lot for fixing this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.