From: "gprocida+abigail at google dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code
Date: Thu, 03 Sep 2020 11:29:44 +0000 [thread overview]
Message-ID: <bug-26571-9487@http.sourceware.org/bugzilla/> (raw)
https://sourceware.org/bugzilla/show_bug.cgi?id=26571
Bug ID: 26571
Summary: get_vmlinux_path_from_kernel_dist contains useless
code
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida+abigail at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
get_vmlinux_path_from_kernel_dist has the following statement:
if (dir_exists(dist_root + "/lib/modules"))
dist_root + "/lib/modules";
It should probably read:
if (dir_exists(dist_root + "/lib/modules"))
dist_root += "/lib/modules";
However, I don't know if the existing behaviour is now relied on by anything.
There is also a confusing (copy/paste?) comment referring to "/usr/lib/debug".
(This bug report was brought to you with the assistance of clang-tidy which
flagged that "dist_root" was an unnecessary copy of "from".)
--
You are receiving this mail because:
You are on the CC list for the bug.
next reply other threads:[~2020-09-03 11:29 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-03 11:29 gprocida+abigail at google dot com [this message]
2020-09-03 11:31 ` [Bug default/26571] " gprocida+abigail at google dot com
2020-09-14 13:57 ` dodji at redhat dot com
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=bug-26571-9487@http.sourceware.org/bugzilla/ \
--to=sourceware-bugzilla@sourceware.org \
--cc=libabigail@sourceware.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).