* [Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code
@ 2020-09-03 11:29 gprocida+abigail at google dot com
2020-09-03 11:31 ` [Bug default/26571] " gprocida+abigail at google dot com
2020-09-14 13:57 ` dodji at redhat dot com
0 siblings, 2 replies; 3+ messages in thread
From: gprocida+abigail at google dot com @ 2020-09-03 11:29 UTC (permalink / raw)
To: libabigail
https://sourceware.org/bugzilla/show_bug.cgi?id=26571
Bug ID: 26571
Summary: get_vmlinux_path_from_kernel_dist contains useless
code
Product: libabigail
Version: unspecified
Status: UNCONFIRMED
Severity: normal
Priority: P2
Component: default
Assignee: dodji at redhat dot com
Reporter: gprocida+abigail at google dot com
CC: libabigail at sourceware dot org
Target Milestone: ---
get_vmlinux_path_from_kernel_dist has the following statement:
if (dir_exists(dist_root + "/lib/modules"))
dist_root + "/lib/modules";
It should probably read:
if (dir_exists(dist_root + "/lib/modules"))
dist_root += "/lib/modules";
However, I don't know if the existing behaviour is now relied on by anything.
There is also a confusing (copy/paste?) comment referring to "/usr/lib/debug".
(This bug report was brought to you with the assistance of clang-tidy which
flagged that "dist_root" was an unnecessary copy of "from".)
--
You are receiving this mail because:
You are on the CC list for the bug.
^ permalink raw reply [flat|nested] 3+ messages in thread* [Bug default/26571] get_vmlinux_path_from_kernel_dist contains useless code 2020-09-03 11:29 [Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code gprocida+abigail at google dot com @ 2020-09-03 11:31 ` gprocida+abigail at google dot com 2020-09-14 13:57 ` dodji at redhat dot com 1 sibling, 0 replies; 3+ messages in thread From: gprocida+abigail at google dot com @ 2020-09-03 11:31 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=26571 --- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> --- The code indentation in the function is also wrong in a couple of places. -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
* [Bug default/26571] get_vmlinux_path_from_kernel_dist contains useless code 2020-09-03 11:29 [Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code gprocida+abigail at google dot com 2020-09-03 11:31 ` [Bug default/26571] " gprocida+abigail at google dot com @ 2020-09-14 13:57 ` dodji at redhat dot com 1 sibling, 0 replies; 3+ messages in thread From: dodji at redhat dot com @ 2020-09-14 13:57 UTC (permalink / raw) To: libabigail https://sourceware.org/bugzilla/show_bug.cgi?id=26571 dodji at redhat dot com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #2 from dodji at redhat dot com --- Right, this is a thinko, of course, and it ought to be fixed. Thank you for spotting this. The obvious fix has been applied to master at https://sourceware.org/git/?p=libabigail.git;a=commit;h=a434894e4dbff278d651b6dd5875fc9b4bfec1bf Thanks! -- You are receiving this mail because: You are on the CC list for the bug. ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2020-09-14 13:57 UTC | newest] Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed) -- links below jump to the message on this page -- 2020-09-03 11:29 [Bug default/26571] New: get_vmlinux_path_from_kernel_dist contains useless code gprocida+abigail at google dot com 2020-09-03 11:31 ` [Bug default/26571] " gprocida+abigail at google dot com 2020-09-14 13:57 ` dodji at redhat dot com
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).