public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26684] abidiff says that some bit field elements missing in version of binary with dwarf5 debuginfo.
Date: Tue, 20 Oct 2020 10:26:27 +0000	[thread overview]
Message-ID: <bug-26684-9487-ENgeGL3qA9@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26684-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26684

--- Comment #13 from dodji at redhat dot com ---
I have put together a patch to support the DW_AT_data_bit_offset attribute and
also to interpret the DW_AT_bit_offset attribute correctly on little endian
machines.

It's available at 
https://sourceware.org/git/?p=libabigail.git;a=commit;h=4e9bfc1212c017cc18f0044b76c37ca3be9ba625,
in the PR26684 branch which can be browsed at
https://sourceware.org/git/?p=libabigail.git;a=shortlog;h=refs/heads/PR26684.

With this patch libabigail should be able to compare two binaries resulting
from the same program, one being compiled with DWARF4 and the other one with
DWARF5.  The result of the comparison should yield the empty set.

The problem now is that abixml files emitted using a previous version of
Libabigail that was doing the wrong interpretation of DW_AT_bit_offset will now
be incompatible with abixml files emitted with this patch.

So, I am thinking about introducing a new abixml version (2.0?) which would be
incompatible with the current 1.0 one.  That way, I can add code to prevent
comparing 1.0 abixml versions against 2.0 ones, as well as comparing 1.0 abixml
files against binaries loaded with the new code.  I'll be working on that now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-10-20 10:26 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-30 18:18 [Bug default/26684] New: " wcohen at redhat dot com
2020-09-30 18:19 ` [Bug default/26684] " wcohen at redhat dot com
2020-09-30 18:20 ` wcohen at redhat dot com
2020-09-30 18:21 ` wcohen at redhat dot com
2020-09-30 18:22 ` wcohen at redhat dot com
2020-10-01 16:01 ` mark at klomp dot org
2020-10-01 17:00 ` wcohen at redhat dot com
2020-10-01 20:50 ` mark at klomp dot org
2020-10-01 20:54 ` mark at klomp dot org
2020-10-01 21:55 ` mark at klomp dot org
2020-10-02 10:07 ` dodji at redhat dot com
2020-10-02 14:42 ` mark at klomp dot org
2020-10-02 14:46 ` mark at klomp dot org
2020-10-02 14:52 ` mark at klomp dot org
2020-10-20 10:26 ` dodji at redhat dot com [this message]
2020-10-23  8:24 ` dodji at redhat dot com
2020-10-23 10:35 ` fche at redhat dot com
2020-10-23 11:29 ` dodji at redhat dot com
2023-01-01 18:09 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26684-9487-ENgeGL3qA9@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).