public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "dodji at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26769] abixml writer misses some member types in the output
Date: Fri, 20 Nov 2020 15:34:58 +0000	[thread overview]
Message-ID: <bug-26769-9487-PIILqVv5fq@http.sourceware.org/bugzilla/> (raw)
In-Reply-To: <bug-26769-9487@http.sourceware.org/bugzilla/>

https://sourceware.org/bugzilla/show_bug.cgi?id=26769

--- Comment #11 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #2)
> dodji, this needs to be a standard unit test:
> 
> $ lib=/lib64/libabigail.so.0.0.0
> $ abidw $lib >bar; abidiff --harmless bar $lib | less
> abidiff: abg-reader.cc:1359: abigail::ir::type_base_sptr
> abigail::xml_reader::read_context::build_or_get_type_decl(const string&,
> bool): Assertion `__abg_cond__' failed.

I agree that this needs to be standard unit test.

The problem though, is that it takes a long time (5+ minutes) on the old
Rawhide box that I use for hacking here.  I guess I'll need to do some
performance work on this front at some point again.

Until, then, I don't feel like making this test be part of the standard "make
check" of the project.

However, I have added a new "make check-self-compare" target to the project
which does exactly that.  I'll run this from time to time and I'll run it for
sure before each release.  If someone has a powerful build box somewhere to run
this, that would be great as well.

The current content of the master branch should now be able to correctly run
this.

Thanks for pointing this out!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

  parent reply	other threads:[~2020-11-20 15:34 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-22  5:10 [Bug default/26769] New: assert when comparing libstdc++ to itself woodard at redhat dot com
2020-10-22  6:00 ` [Bug default/26769] " woodard at redhat dot com
2020-10-23  4:48 ` woodard at redhat dot com
2020-10-23 22:22 ` woodard at redhat dot com
2020-11-10 10:22 ` dodji at redhat dot com
2020-11-12 22:23 ` woodard at redhat dot com
2020-11-16 17:15 ` dodji at redhat dot com
2020-11-16 20:33 ` woodard at redhat dot com
2020-11-17 17:39   ` Dodji Seketeli
2020-11-19 10:13   ` Dodji Seketeli
2020-11-17 17:39 ` dodji at seketeli dot org
2020-11-17 17:50 ` woodard at redhat dot com
2020-11-19 16:56 ` dodji at redhat dot com
2020-11-19 16:58 ` [Bug default/26769] abixml writer misses some member types in the output dodji at redhat dot com
2020-11-20 15:29 ` dodji at redhat dot com
2020-11-20 15:34 ` dodji at redhat dot com [this message]
2020-11-20 17:49 ` dodji at seketeli dot org
2020-11-20 22:29 ` woodard at redhat dot com
2020-11-23 12:26 ` dodji at redhat dot com
2020-11-23 17:42 ` woodard at redhat dot com
2020-11-24 10:39 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26769-9487-PIILqVv5fq@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).