public inbox for libabigail@sourceware.org
 help / color / mirror / Atom feed
From: "woodard at redhat dot com" <sourceware-bugzilla@sourceware.org>
To: libabigail@sourceware.org
Subject: [Bug default/26776] New: harmless changes indicate incomplete representation of ABI
Date: Fri, 23 Oct 2020 04:31:47 +0000	[thread overview]
Message-ID: <bug-26776-9487@http.sourceware.org/bugzilla/> (raw)

https://sourceware.org/bugzilla/show_bug.cgi?id=26776

            Bug ID: 26776
           Summary: harmless changes indicate incomplete representation of
                    ABI
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

$ abidw /lib64/libkrb5.so.3.3 >bar; abidiff --harmless bar
/lib64/libkrb5.so.3.3
Functions changes summary: 0 Removed, 7 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

7 functions with some indirect sub-type change:

  [C]'function void k5_rc_close(krb5_context, krb5_rcache)' at rc_base.c:118:1
has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        in pointed to type 'struct krb5_rc_st' at rc-int.h:41:1:
          type size hasn't changed
          type struct krb5_rc_st was a declaration-only type and is now a
defined type
  [C]'function const char* k5_rc_get_name(krb5_context, krb5_rcache)' at
rc_base.c:139:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier

  [C]'function krb5_error_code k5_rc_resolve(krb5_context, const char*,
krb5_rcache*)' at rc_base.c:70:1 has some indirect sub-type changes:
    parameter 3 of type 'krb5_rcache*' has sub-type changes:
      pointed to type 'typedef krb5_rcache' changed at krb5.h:2717:1, as
reported earlier

  [C]'function krb5_error_code krb5_rc_default(krb5_context, krb5_rcache*)' at
rc_base.c:177:1 has some indirect sub-type changes:
    parameter 2 of type 'krb5_rcache*' has sub-type changes:
      pointed to type 'typedef krb5_rcache' changed at krb5.h:2717:1, as
reported earlier

  [C]'function krb5_error_code krb5_rc_destroy(krb5_context, krb5_rcache)' at
rc_base.c:183:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier

  [C]'function krb5_error_code krb5_rc_get_lifespan(krb5_context, krb5_rcache,
krb5_deltat*)' at rc_base.c:189:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier

  [C]'function krb5_error_code krb5_rc_initialize(krb5_context, krb5_rcache,
krb5_deltat)' at rc_base.c:195:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier


[ben@alien test]$ abidw /lib64/libkrb5.so.3.3 >bar; abidiff  bar
/lib64/libkrb5.so.3.3
Functions changes summary: 0 Removed, 0 Changed (7 filtered out), 0 Added
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

$ rpm -qf /lib64/libkrb5.so.3.3
krb5-libs-1.18.2-22.fc33.x86_64
$ rpm -q libabigail
libabigail-1.7-2.fc33.x86_64

The fact that these are reported even as harmless changes to the ABI even when
they are an identity indicates that the ABI is not being fully represented in
the abidw file generated by abidw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

             reply	other threads:[~2020-10-23  4:31 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-23  4:31 woodard at redhat dot com [this message]
2020-10-23  4:39 ` [Bug default/26776] " woodard at redhat dot com
2020-10-31 11:27 ` dodji at redhat dot com
2020-11-25  0:50 ` [Bug default/26776] declaration-only type and is now a defined type woodard at redhat dot com
2020-11-30  7:50 ` dodji at redhat dot com

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=bug-26776-9487@http.sourceware.org/bugzilla/ \
    --to=sourceware-bugzilla@sourceware.org \
    --cc=libabigail@sourceware.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).