[Bug default/26776] New: harmless changes indicate incomplete representation of ABI

[Bug default/26776] New: harmless changes indicate incomplete representation of ABI

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26776

            Bug ID: 26776
           Summary: harmless changes indicate incomplete representation of
                    ABI
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

$ abidw /lib64/libkrb5.so.3.3 >bar; abidiff --harmless bar
/lib64/libkrb5.so.3.3
Functions changes summary: 0 Removed, 7 Changed, 0 Added functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

7 functions with some indirect sub-type change:

  [C]'function void k5_rc_close(krb5_context, krb5_rcache)' at rc_base.c:118:1
has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        in pointed to type 'struct krb5_rc_st' at rc-int.h:41:1:
          type size hasn't changed
          type struct krb5_rc_st was a declaration-only type and is now a
defined type
  [C]'function const char* k5_rc_get_name(krb5_context, krb5_rcache)' at
rc_base.c:139:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier

  [C]'function krb5_error_code k5_rc_resolve(krb5_context, const char*,
krb5_rcache*)' at rc_base.c:70:1 has some indirect sub-type changes:
    parameter 3 of type 'krb5_rcache*' has sub-type changes:
      pointed to type 'typedef krb5_rcache' changed at krb5.h:2717:1, as
reported earlier

  [C]'function krb5_error_code krb5_rc_default(krb5_context, krb5_rcache*)' at
rc_base.c:177:1 has some indirect sub-type changes:
    parameter 2 of type 'krb5_rcache*' has sub-type changes:
      pointed to type 'typedef krb5_rcache' changed at krb5.h:2717:1, as
reported earlier

  [C]'function krb5_error_code krb5_rc_destroy(krb5_context, krb5_rcache)' at
rc_base.c:183:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier

  [C]'function krb5_error_code krb5_rc_get_lifespan(krb5_context, krb5_rcache,
krb5_deltat*)' at rc_base.c:189:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier

  [C]'function krb5_error_code krb5_rc_initialize(krb5_context, krb5_rcache,
krb5_deltat)' at rc_base.c:195:1 has some indirect sub-type changes:
    parameter 2 of type 'typedef krb5_rcache' has sub-type changes:
      underlying type 'krb5_rc_st*' changed:
        pointed to type 'struct krb5_rc_st' changed, as reported earlier


[ben@alien test]$ abidw /lib64/libkrb5.so.3.3 >bar; abidiff  bar
/lib64/libkrb5.so.3.3
Functions changes summary: 0 Removed, 0 Changed (7 filtered out), 0 Added
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

$ rpm -qf /lib64/libkrb5.so.3.3
krb5-libs-1.18.2-22.fc33.x86_64
$ rpm -q libabigail
libabigail-1.7-2.fc33.x86_64

The fact that these are reported even as harmless changes to the ABI even when
they are an identity indicates that the ABI is not being fully represented in
the abidw file generated by abidw.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26776] harmless changes indicate incomplete representation of ABI

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26776

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
Another library which has many similar problmes is /lib64/libssh.so.4.8.6 in
this library it is much worse than in the krb5 library but the problems are
much worse. 

$ abidw $lib >bar; abidiff bar $lib | less
Functions changes summary: 0 Removed, 0 Changed (304 filtered out), 0 Added
functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

$ rpm -qf /lib64/libssh.so.4.8.6
libssh-0.9.5-1.fc33.x86_64

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26776] harmless changes indicate incomplete representation of ABI

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26776

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26776] declaration-only type and is now a defined type

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26776

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|harmless changes indicate   |declaration-only type and
                   |incomplete representation   |is now a defined type
                   |of ABI                      |

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
This is a very big problem and it affects the following _220_ libraries in my
test:

libAnacondaWidgets.so.4.0.0
libaom.so.2.0.0
libappstream-glib.so.8.0.10
libapr-1.so.0.7.0
libaprutil-1.so.0.6.1
libarchive.so.13.4.3
libasound.so.2.0.0
libatk-1.0.so.0.23609.1
libatk-bridge-2.0.so.0.0.0
libavahi-core.so.7.1.0
libbabeltrace-ctf.so.1.0.0
libbabeltrace.so.1.0.0
libbluray.so.2.3.0
libbrasero-media3.so.1.2.6
libcacard.so.0.0.0
libcairo.so.2.11600.0
libcamel-1.2.so.62.0.0
libcanberra.so.0.2.5
libchamplain-0.12.so.0.11.10
libclutter-1.0.so.0.2600.4
libclutter-gst-3.0.so.0.27.0
libcogl-pango.so.20.4.3
libcogl-path.so.20.4.3
libcogl.so.20.4.3
libcolord.so.2.0.5
libcrypto.so.1.1.1h
libcue.so.2.2.1
libcurl.so.4.6.0
libczmq.so.4.2.0
libdatrie.so.1.3.2
libdazzle-1.0.so.0
libdbus-1.so.3.19.13
libdcerpc.so.0.0.1
libdleyna-core-1.0.so.5.0.0
libdleyna-renderer-1.0.so.1.0.3
libdleyna-server-1.0.so.1.0.3
libdmapsharing-3.0.so.2.9.41
libdns.so.1112.0.0
libdrm_radeon.so.1.0.1
libdvdnav.so.4.2.0
libdvdread.so.7.0.0
libebackend-1.2.so.10.0.0
libedata-book-1.2.so.26.0.0
libedataserverui-1.2.so.2.0.0
libedit.so.0.0.63
libevent-2.1.so.6.0.2
libevent_core-2.1.so.6.0.2
libevent_extra-2.1.so.6.0.2
libevview3.so.3.0.0
libexif.so.12.3.4
libext2fs.so.2.4
libfolks-dummy.so.25.21.0
libfolks.so.25.21.0
libfontconfig.so.1.12.0
libfprint-2.so.2.0.0
libfreetype.so.6.17.4
libfuse3.so.3.9.3
libfuse.so.2.9.9
libgavl.so.1.0.0
libgcalc-2.so.1
libgcr-base-3.so.1.0.0
libgcr-ui-3.so.1.0.0
libgcrypt.so.20.2.6
libgdata.so.22.5.2
libgdk-3.so.0.2404.19
libgdk-x11-2.0.so.0.2400.32
libgee-0.8.so.2.6.1
libgegl-0.4.so.0.425.1
libgeocode-glib.so.0.0.0
libges-1.0.so.0.1800.0
libgfbgraph-0.2.so.0.0.0
libgfrpc.so.0.0.1
libgio-2.0.so.0.6600.3
libgnome-desktop-3.so.19.0.9
libgnutls.so.30.28.1
libgobject-2.0.so.0.6600.3
libgom-1.0.so.0.1.0
libgpgme.so.11.23.0
libgrss.so.0.700.0
libgs.so.9.53
libgstaudio-1.0.so.0.1801.0
libgstcheck-1.0.so.0.1801.0
libgstgl-1.0.so.0.1801.0
libgstreamer-1.0.so.0.1801.0
libgstrtp-1.0.so.0.1801.0
libgstvideo-1.0.so.0.1801.0
libgtk-3.so.0.2404.19
libgtksourceview-4.so.0.0.0
libgtk-vnc-2.0.so.0.0.2
libgtk-x11-2.0.so.0.2400.32
libgudev-1.0.so.0.3.0
libgupnp-1.2.so.0.0.0
libgupnp-av-1.0.so.2.0.0
libgupnp-dlna-2.0.so.3.0.0
libgutenprint.so.9.4.0
libgvc.so.6.0.0
libgvplugin_core.so.6.0.0
libgvpr.so.2.0.0
libgweather-3.so.16.0.0
libgxps.so.2.2.3
libhandy-0.0.so.0
libhandy-1.so.0
libhgfs.so.0.0.0
libhogweed.so.5.0
libhogweed.so.6.0
libibus-1.0.so.5.0.523
libical-glib.so.3.0.8
libical.so.3.0.8
libICE.so.6.3.0
libipset.so.13.1.0
libiptcdata.so.0.3.3
libipt.so.2.0.2
libirs.so.161.0.1
libiscsi.so.9.0.0
libisc.so.1107.0.2
libisl.so.13.1.0
libisl.so.15.1.1
libisns.so.0
libjcat.so.1.0.0
libjq.so.1.0.4
libkadm5clnt_mit.so.12.0
libkrb5.so.3.3
liblangtag.so.1.4.1
liblttng-ust.so.0.0.0
libMagickCore-6.Q16.so.6.0.0
libMagickWand-6.Q16.so.6.0.0
libmm-glib.so.0.6.0
libmodulemd.so.2.9.4
libmp3lame.so.0.0.0
libmutter-7.so.0.0.0
libmutter-clutter-7.so.0.0.0
libmutter-cogl-7.so.0.0.0
libmutter-cogl-pango-7.so.0.0.0
libneon.so.27.4.2
libnetsnmp.so.40.0.0
libnftables.so.1.0.0
libnl-idiag-3.so.200.26.0
libnl-e-3.so.200.26.0.out
libnm.so.0.1.0
libonig.so.5.1.0
libopenjp2.so.2.3.1
libosinfo-1.0.so.0.1008.0
libpango-1.0.so.0.4800.0
libpangoft2-1.0.so.0.4800.0
libpgm-5.2.so.0.0.122
libpipewire-0.2.so.1.207.0
libply-splash-core.so.4.0.0
libply-splash-graphics.so.4.0.0
libqb.so.100.0.1
libqmi-glib.so.5.7.0
libraptor2.so.0.0.0
librasqal.so.3.0.0
libraw1394.so.11.1.0
libreport.so.1.0.0
librest-0.7.so.0.0.0
librhythmbox-core.so.10.0.0
librpmbuild.so.9.1.0
librpmio.so.9.1.0
librpm.so.9.1.0
librygel-core-2.6.so.2.0.4
librygel-renderer-2.6.so.2.0.4
librygel-server-2.6.so.2.0.4
libsamba-credentials.so.0.0.1
libsamba-passdb.so.0.28.0
libsane-hp.so.1.0.31
libsatyr.so.4.0.0
libSDL2-2.0.so.0.12.0
libsecret-1.so.0.0.0
libsepol.so.1
libs.so.3.2.0.out
libsmbclient.so.0.6.0
libsolv.so.1
libsoup-2.4.so.1.11.0
libspectre.so.1.1.9
libspeexdsp.so.1.5.1
libspice-client-glib-2.0.so.8.6.0
libspice-server.so.1.14.0
libssh2.so.1.0.1
libssh.so.4.8.6
libsss_idmap.so.0.5.1
libstartup-notification-1.so.0.0.0
libsyn123.so.0.1.1
libsystemd.so.0.29.0
libtdb.so.1.4.3
libteam.so.5.6.1
libtepl-5.so.0.0.0
libtextstyle.so.0.1.1
libtimezonemap.so.1.0.0
libtotem.so.0.0.0
libtracker-miner-2.0.so.0.306.0
libtracker-sparql-2.0.so.0.306.0
libtracker-sparql-3.0.so.0.1.0
libtss2-fapi.so.1.0.0
libudev.so.1.6.18
libunistring.so.2.1.0
libusal.so.0.0.1
libv4lconvert.so.0.0.0
libvirt-gconfig-1.0.so.0.3000.0
libvirt-gobject-1.0.so.0.3000.0
libvirt.so.0.6006.0
libvmtools.so.0.0.0
libvncserver.so.0.9.13
libvolume_key.so.1.2.3
libwayland-server.so.0.1.0
libwsman.so.1.0.0
libX11.so.6.3.0
libxatracker.so.2.5.0
libxcb.so.1.1.0
libxenlight.so.4.14.0
libxml2.so.2.9.10
libxmlb.so.2.0.0
libxmlrpc_abyss.so.3.51
libxmlrpc_client.so.3.51
libxmlsec1.so.1.2.29
libXmu.so.6.2.0
libXmuu.so.1.0.0
libxslt.so.1.1.34
libXt.so.6.0.0
libzapojit-0.0.so.0.0.0
libzstd.so.1.4.5

This is the majority of my test failures.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26776] declaration-only type and is now a defined type

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26776

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #3 from dodji at redhat dot com ---
This now works for me with the master branch which tip commit is:

2417efb2 dwarf-reader: Bug 26908 - don't crash on empty DW_TAG_partial_unit

Thanks for reporting this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.