[Bug default/26783] New: abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[Bug default/26783] New: abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

            Bug ID: 26783
           Summary: abidiff aborts void
                    abigail::comparison::corpus_diff::priv::ensure_lookup_
                    tables_populated()
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This crash is unique

$ lib=/lib64/libicutest.so.67.1
$ rpm -qf $lib
libicu-67.1-4.fc33.x86_64
$ abidw $lib > 1.dw
$ gdb --silent --args abidiff 1.dw $lib
Reading symbols from abidiff...
(gdb) r
Starting program: /home/ben/Scratch/Work/test/libabigail-x86_64/bin/abidiff
1.dw /lib64/libicutest.so.67.1
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".
abidiff: ../../../libabigail/src/abg-comparison.cc:8983: void
abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated():
Assertion `__abg_cond__' failed.

Program received signal SIGABRT, Aborted.
__GI_raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:49
49        return ret;
(gdb) bt
#0  __GI_raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:49
#1  0x00007ffff75098a4 in __GI_abort () at abort.c:79
#2  0x00007ffff7509789 in __assert_fail_base (fmt=0x7ffff7676e68 "%s%s%s:%u:
%s%sAssertion `%s' failed.\n%n", assertion=0x7ffff7f3bfa4 "__abg_cond__", 
    file=0x7ffff7f3edb8 "../../../libabigail/src/abg-comparison.cc", line=8983,
function=<optimized out>) at assert.c:92
#3  0x00007ffff7518fc6 in __GI___assert_fail (assertion=0x7ffff7f3bfa4
"__abg_cond__", file=0x7ffff7f3edb8
"../../../libabigail/src/abg-comparison.cc", line=8983, 
    function=0x7ffff7f40ea8 "void
abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()") at
assert.c:101
#4  0x00007ffff7e10e15 in
abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated
(this=0x7e9e10) at ../../../libabigail/src/abg-comparison.cc:9183
#5  0x00007ffff7e11534 in abigail::comparison::compute_diff
(f=std::shared_ptr<class abigail::ir::corpus> (use count 3, weak count 0) =
{...}, s=..., ctxt=...)
    at /usr/include/c++/10/bits/shared_ptr_base.h:1324
#6  0x00000000004067cf in main (argc=<optimized out>, argv=<optimized out>) at
/usr/include/c++/10/bits/shared_ptr_base.h:736
(gdb)

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This continues to be a problem with the latest git up through
2cc1ab7ee879da20688c4a72ec93c73123d7b9aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
This continues to be a problem with With commit 2c0dd017 from dodji/PR26769

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #3 from dodji at redhat dot com ---
I can't reproduce this with current master which commit is:

18b0693c abipkgdiff: minor cleanups

Thanks for reporting this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |---
             Status|RESOLVED                    |REOPENED

--- Comment #4 from Ben Woodard <woodard at redhat dot com> ---
Dodji how are you testing this? I'm genuinely perplexed. This continues to
reproduce for me with commit 2417efb2. The backtrace is the same but the line
number has shifted slightly which is further indication to me that I am running
the correct codebase.

The key difference is that now it is crashing at line 9004 rather than 8983

#4  0x00007ffff7e10dc4 in
abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated
(this=0x71e5c0) at ../../../libabigail/src/abg-comparison.cc:9004
#5  0x00007ffff7e11534 in abigail::comparison::compute_diff
(f=std::shared_ptr<abigail::ir::corpus> (use count 3, weak count 0) = {...},
s=..., ctxt=...) at /usr/include/c++/10/bits/shared_ptr_base.h:1324
#6  0x0000000000406443 in load_corpus_and_write_abixml (opts=...,
context=std::shared_ptr<abigail::dwarf_reader::read_context> (empty) = {...},
env=std::shared_ptr<abigail::ir::environment> (use count 1, weak count 0) =
{...}, argv=0x7fffffffdb58) at ../../../libabigail/tools/abidw.cc:590
#7  main (argc=<optimized out>, argv=0x7fffffffdb58) at
../../../libabigail/tools/abidw.cc:866

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

--- Comment #5 from dodji at redhat dot com ---
Created attachment 13015
  --> https://sourceware.org/bugzilla/attachment.cgi?id=13015&action=edit
Trace of how I am testing/reproducing this

To test this, I download the RPMs from Koji, I unpack them and run
abidw/abidiff on them.  I make sure to use libabigail binaries from the local
build, even before installing them.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

--- Comment #6 from dodji at redhat dot com ---
(In reply to Ben Woodard from comment #4)
> Dodji how are you testing this? 

I have attached a trace of how I reproduce this.  I have tried again to
reproduce it and I could not.  When I git checkout to an anterior-enough tree,
I can reproduce the issue.  So I am quite certain of what I am seeing.  I am
not sure about what's going on here.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26783] abidiff aborts void abigail::comparison::corpus_diff::priv::ensure_lookup_tables_populated()

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26783

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|---                         |WORKSFORME

--- Comment #7 from Ben Woodard <woodard at redhat dot com> ---
dodji and I sorted out the problem that led to us getting different results.

-- 
You are receiving this mail because:
You are on the CC list for the bug.