[Bug default/26785] New: abidiff crashes in abigail::ir::corpus::priv::build_unreferenced_symbols_tables () when comparing a library to itself

[Bug default/26785] New: abidiff crashes in abigail::ir::corpus::priv::build_unreferenced_symbols_tables () when comparing a library to itself

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26785

            Bug ID: 26785
           Summary: abidiff crashes in
                    abigail::ir::corpus::priv::build_unreferenced_symbols_
                    tables () when comparing a library to itself
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

This is another unique crash when comparing a library to itself.

$ lib=/lib64/libHalf.so.24.0.0
$ rpm -qf $lib
ilmbase-2.3.0-5.fc33.x86_64
$ abidw $lib > 1.dw
$ gdb --silent --args abidiff 1.dw $lib
Reading symbols from abidiff...
(gdb) r
Starting program: /home/ben/Scratch/Work/test/libabigail-x86_64/bin/abidiff
1.dw /lib64/libHalf.so.24.0.0
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGSEGV, Segmentation fault.
abigail::ir::corpus::priv::build_unreferenced_symbols_tables (this=0x4471a0) at
../../../libabigail/src/abg-corpus.cc:357
357         if ((sym = (*v)->get_symbol()))
(gdb) bt
#0  abigail::ir::corpus::priv::build_unreferenced_symbols_tables
(this=0x4471a0) at ../../../libabigail/src/abg-corpus.cc:357
#1  0x00007ffff7dd387d in
abigail::ir::corpus::get_unreferenced_function_symbols (this=0x4477b0) at
../../../libabigail/src/abg-corpus.cc:1423
#2  0x00007ffff7e1139c in abigail::comparison::compute_diff
(f=std::shared_ptr<abigail::ir::corpus> (use count 3, weak count 0) = {...}, 
    s=std::shared_ptr<abigail::ir::corpus> (use count 3, weak count 0) = {...}, 
    ctxt=std::shared_ptr<abigail::comparison::diff_context> (use count 2, weak
count 1) = {...}) at /usr/include/c++/10/bits/shared_ptr_base.h:1324
#3  0x00000000004067cf in main (argc=<optimized out>, argv=<optimized out>) at
/usr/include/c++/10/bits/shared_ptr_base.h:736
(gdb) q
A debugging session is active.

        Inferior 1 [process 441926] will be killed.

Quit anyway? (y or n) y

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26785] abidiff crashes in abigail::ir::corpus::priv::build_unreferenced_symbols_tables () when comparing a library to itself

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26785

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
This problem continues to exist with the latest trunk up to commit
2cc1ab7ee879da20688c4a72ec93c73123d7b9aa

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26785] abidiff crashes in abigail::ir::corpus::priv::build_unreferenced_symbols_tables () when comparing a library to itself

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26785

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
verified that this continues to happen with commit 2c0dd017 from dodji/PR26769

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26785] abidiff crashes in abigail::ir::corpus::priv::build_unreferenced_symbols_tables () when comparing a library to itself

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26785

--- Comment #3 from dodji at redhat dot com ---
I can't reproduce this with the current master.  I got the RPMs (including the
debuginfo ones) from koji to make sure we are looking at the same thing.

And the comparison runs just fine.  Is this still crashing for you?

Here is the tip of the git tree I am seeing:

c2ce1a38 dwarf-reader: support artificially generated translation units

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26785] abidiff crashes in abigail::ir::corpus::priv::build_unreferenced_symbols_tables () when comparing a library to itself

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26785

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #4 from dodji at redhat dot com ---
closing for now, please re-open this if I missed something.

Thanks for reporting this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.