[Bug default/26940] New: assert in finish_member_function_reading when running abidw

[Bug default/26940] New: assert in finish_member_function_reading when running abidw

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26940

            Bug ID: 26940
           Summary: assert in finish_member_function_reading when running
                    abidw
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

With commit 2c0dd017 from dodji/PR26769 I get 

/home/ben/Scratch/Work/test/libabigail-x86_64/bin/abidw --abidiff
/lib64/libGLU.so.1.3.1
[Thread debugging using libthread_db enabled]
Using host libthread_db library "/lib64/libthread_db.so.1".

Program received signal SIGABRT, Aborted.
__GI_raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:49
49        return ret;
#0  __GI_raise (sig=<optimized out>) at ../sysdeps/unix/sysv/linux/raise.c:49
#1  0x00007ffff750a8a4 in __GI_abort () at abort.c:79
#2  0x00007ffff750a789 in __assert_fail_base (fmt=0x7ffff7677680 "%s%s%s:%u:
%s%sAssertion `%s' failed.\n%n", assertion=0x7ffff7f3bfa4 "__abg_cond__",
file=0x7ffff7f49938 "../../../libabigail/src/abg-dwarf-reader.cc", line=13223,
function=<optimized out>) at assert.c:92
#3  0x00007ffff751a026 in __GI___assert_fail (assertion=0x7ffff7f3bfa4
"__abg_cond__", file=0x7ffff7f49938
"../../../libabigail/src/abg-dwarf-reader.cc", line=13223,
function=0x7ffff7f4a758 "void
abigail::dwarf_reader::finish_member_function_reading(Dwarf_Die*, const
function_decl_sptr&, const class_or_union_sptr&,
abigail::dwarf_reader::read_context&)") at assert.c:101
#4  0x00007ffff7ecc634 in abigail::dwarf_reader::finish_member_function_reading
(die=0x7fffffffc8b0, f=std::shared_ptr<abigail::ir::function_decl> (use count
3, weak count 0) = {...}, klass=std::shared_ptr<abigail::ir::class_or_union>
(use count 2, weak count 0) = {...}, ctxt=...) at
../../../libabigail/src/abg-dwarf-reader.cc:13223
#5  0x00007ffff7ed2254 in abigail::dwarf_reader::build_ir_node_from_die
(ctxt=..., die=0x7fffffffc8b0, scope=0x7b2f80,
called_from_public_decl=<optimized out>, where_offset=149198,
is_declaration_only=<optimized out>, is_required_decl_spec=false) at
../../../libabigail/src/abg-dwarf-reader.cc:16748
#6  0x00007ffff7ee0450 in abigail::dwarf_reader::add_or_update_member_function
(where_offset=149198, called_from_public_decl=true,
class_type=std::shared_ptr<abigail::ir::class_or_union> (use count 10, weak
count 2) = {...}, function_die=0x7fffffffc8b0, ctxt=...) at
/usr/include/c++/10/bits/shared_ptr_base.h:1324
#7  abigail::dwarf_reader::add_or_update_class_type (ctxt=...,
die=0x7fffffffcd30, scope=<optimized out>, is_struct=<optimized out>,
klass=..., called_from_public_decl=true, where_offset=149198,
is_declaration_only=true) at ../../../libabigail/src/abg-dwarf-reader.cc:13870
#8  0x00007ffff7ed1c7b in abigail::dwarf_reader::build_ir_node_from_die
(ctxt=..., die=0x7fffffffcd30, scope=0x62f840,
called_from_public_decl=<optimized out>, where_offset=149198,
is_declaration_only=true, is_required_decl_spec=false) at
../../../libabigail/src/abg-dwarf-reader.cc:16506
#9  0x00007ffff7ed3770 in abigail::dwarf_reader::build_ir_node_from_die
(ctxt=..., die=0x7fffffffcd30, called_from_public_decl=<optimized out>,
where_offset=149198) at /usr/include/c++/10/bits/shared_ptr_base.h:1324
#10 0x00007ffff7ed8696 in abigail::dwarf_reader::build_pointer_type_def
(ctxt=..., die=0x7fffffffd240, called_from_public_decl=<optimized out>,
where_offset=149198) at ../../../libabigail/src/abg-dwarf-reader.cc:14391
#11 0x00007ffff7ed122d in abigail::dwarf_reader::build_ir_node_from_die
(ctxt=..., die=0x7fffffffd240, scope=0x62f840,
called_from_public_decl=<optimized out>, where_offset=149198,
is_declaration_only=false, is_required_decl_spec=false) at
../../../libabigail/src/abg-dwarf-reader.cc:16363
#12 0x00007ffff7ed3770 in abigail::dwarf_reader::build_ir_node_from_die
(ctxt=..., die=0x7fffffffd240, called_from_public_decl=<optimized out>,
where_offset=149198) at /usr/include/c++/10/bits/shared_ptr_base.h:1324
#13 0x00007ffff7eda4e8 in abigail::dwarf_reader::build_function_type (ctxt=...,
die=0x7fffffffd800, is_method=..., where_offset=149198) at
../../../libabigail/src/abg-dwarf-reader.cc:14655
#14 0x00007ffff7edb088 in abigail::dwarf_reader::build_function_decl (ctxt=...,
die=0x7fffffffd800, where_offset=149198,
fn=std::shared_ptr<abigail::ir::function_decl> (empty) = {...}) at
../../../libabigail/src/abg-dwarf-reader.cc:15654
#15 0x00007ffff7ed0a82 in
abigail::dwarf_reader::build_or_get_fn_decl_if_not_suppressed (result=...,
is_declaration_only=false, where_offset=149198, fn_die=0x7fffffffd800,
scope=<optimized out>, ctxt=...) at
../../../libabigail/src/abg-dwarf-reader.cc:15330
#16 abigail::dwarf_reader::build_ir_node_from_die (ctxt=...,
die=0x7fffffffd800, scope=0x62f840, called_from_public_decl=<optimized out>,
where_offset=149198, is_declaration_only=false, is_required_decl_spec=false) at
../../../libabigail/src/abg-dwarf-reader.cc:16737
#17 0x00007ffff7ed3770 in abigail::dwarf_reader::build_ir_node_from_die
(ctxt=..., die=0x7fffffffd800, called_from_public_decl=<optimized out>,
where_offset=149198) at /usr/include/c++/10/bits/shared_ptr_base.h:1324
#18 0x00007ffff7ee3080 in
abigail::dwarf_reader::build_translation_unit_and_add_to_ir (ctxt=...,
die=<optimized out>, address_size=<optimized out>) at
../../../libabigail/src/abg-dwarf-reader.cc:8556
#19 0x00007ffff7ee4f3a in abigail::dwarf_reader::read_debug_info_into_corpus
(ctxt=...) at ../../../libabigail/src/abg-dwarf-reader.cc:15936
#20 abigail::dwarf_reader::read_corpus_from_elf (ctxt=...,
status=@0x7fffffffda3c: abigail::dwarf_reader::STATUS_UNKNOWN) at
../../../libabigail/src/abg-dwarf-reader.cc:17149
#21 0x0000000000405c93 in load_corpus_and_write_abixml (opts=...,
context=std::shared_ptr<abigail::dwarf_reader::read_context> (use count 1, weak
count 0) = {...}, env=std::shared_ptr<abigail::ir::environment> (use count 1,
weak count 0) = {...}, argv=0x7fffffffdf88) at
../../../libabigail/tools/abidw.cc:494
#22 main (argc=<optimized out>, argv=0x7fffffffdf88) at
../../../libabigail/tools/abidw.cc:866

from mesa-libGLU-9.0.1-3.fc33.x86_64

This looks like a remaining corner case from PR26769 that I didn't pick up last
time.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26940] assert in finish_member_function_reading when running abidw

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26940

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|NEW                         |RESOLVED

--- Comment #1 from dodji at redhat dot com ---
This now works for me in master which has this commit at its tip:

18b0693c abipkgdiff: minor cleanups

Thanks for reporting this!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26940] assert in finish_member_function_reading when running abidw

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26940

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|WORKSFORME                  |---
             Status|RESOLVED                    |REOPENED

--- Comment #2 from Ben Woodard <woodard at redhat dot com> ---
I'm still reproducing this problem with 2417efb2 in the libabigail trunk. 

I am not sure why I would be seeing it and you wouldn't. I double checked that
I was on the right branch, killed my build directory and my test install
directory then rebuilt them from scratch and double checked that I was running
the correct version of libabigail in my test scripts.

The backtrace that I'm getting appears to be the same.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26940] assert in finish_member_function_reading when running abidw

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26940

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |WORKSFORME
             Status|REOPENED                    |RESOLVED

--- Comment #3 from Ben Woodard <woodard at redhat dot com> ---
sorted out the problem

-- 
You are receiving this mail because:
You are on the CC list for the bug.