[Bug default/26992] New: type struct <name> was a declaration-only type and is now a defined type

[Bug default/26992] New: type struct <name> was a declaration-only type and is now a defined type

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26992

            Bug ID: 26992
           Summary: type struct <name> was a declaration-only type and is
                    now a defined type
           Product: libabigail
           Version: unspecified
            Status: NEW
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: woodard at redhat dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

When abidw --abidiff /lib64/libcogl.so.20.4.3 I get a lot of changes.
from cogl-1.22.8-2.fc33.x86_64

The crux of the problem seems to be:

underlying type 'struct _CoglOnscreenTemplate' changed:
  type struct _CoglOnscreenTemplate was a declaration-only type and is now a
defined type

and

                                                              type changed
from:
 union {struct {int width; int height; int depth;} sized; struct {CoglBitmap*
bitmap; int height; int depth; CoglBool can_convert_in_place;} bitmap; struct
{EGLImageKHR image; int width; int height; CoglPixelFormat format;} egl_image;
struct {int width; int height; unsigned int gl_handle; CoglPixelFormat format;}
gl_foreign;}
                                                              to:
 union {struct {int width; int height; int depth;} sized; struct {CoglBitmap*
bitmap; int height; int depth; CoglBool can_convert_in_place;} bitmap; struct
{EGLImageKHR image; int width; int height; CoglPixelFormat format;} egl_image;
struct {int width; int height; unsigned int gl_handle; CoglPixelFormat format;}
gl_foreign;}
                        type changed from:
union {struct {CoglAttributeBuffer* attribute_buffer; size_t stride; size_t
offset; int n_components; CoglAttributeType type;} buffered; struct
{CoglContext* context; CoglBoxedValue boxed;} constant;}
                        to:
union {struct {CoglAttributeBuffer* attribute_buffer; size_t stride; size_t
offset; int n_components; CoglAttributeType type;} buffered; struct
{CoglContext* context; CoglBoxedValue boxed;} constant;}

So there are two distinct kinds of changes. One has to do with unions and the
other has to do with declaration only type changing to defined type.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26992] type struct <name> was a declaration-only type and is now a defined type

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26992

--- Comment #1 from Ben Woodard <woodard at redhat dot com> ---
abidw --abidiff /lib64/libgs.so.9.53
from libgs-9.53.3-2.fc33.x86_64

                          type changed from:
                            union {gs_ref_memory_t* indexed[4]; _ssn named;}
                          to:
                            union {gs_ref_memory_t* indexed[4]; _ssn named;}

seems to have the same problem with anonymous unions.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26992] type struct <name> was a declaration-only type and is now a defined type

[woodard at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26992

Ben Woodard <woodard at redhat dot com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Blocks|                            |27019


Referenced Bugs:

https://sourceware.org/bugzilla/show_bug.cgi?id=27019
[Bug 27019] BUILD metabug
-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26992] type struct <name> was a declaration-only type and is now a defined type

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26992

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/26992] type struct <name> was a declaration-only type and is now a defined type

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=26992

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
         Resolution|---                         |FIXED
             Status|ASSIGNED                    |RESOLVED

--- Comment #2 from dodji at redhat dot com ---
This should be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=625d0903c22ae1293c8af999e5eb17536e210def
in the master branch of the Git repository.

Thanks for taking the time to file this issue!

-- 
You are receiving this mail because:
You are on the CC list for the bug.