[Bug default/27162] New: libabigail appears to lose declarations for common symbols

[Bug default/27162] New: libabigail appears to lose declarations for common symbols

[gprocida+abigail at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27162

            Bug ID: 27162
           Summary: libabigail appears to lose declarations for common
                    symbols
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: gprocida+abigail at google dot com
                CC: libabigail at sourceware dot org
  Target Milestone: ---

libabigail appears to lose declarations for common symbols.

$ cat bar.c
int arg[2];
$ gcc -fno-common -g -Wall -Wextra -c bar.c
$ ~/android/libabigail/build/tools/abidw bar.o
<abi-corpus path='bar.o' architecture='elf-amd-x86_64'>
  <elf-variable-symbols>
    <elf-symbol name='arg' size='8' type='object-type' binding='global-binding'
visibility='default-visibility' is-defined='yes'/>
  </elf-variable-symbols>
  <abi-instr version='1.0' address-size='64' path='bar.c' comp-dir-path='/tmp'
language='LANG_C99'>
    <type-decl name='int' size-in-bits='32' id='type-id-1'/>
    <array-type-def dimensions='1' type-id='type-id-1' size-in-bits='64'
id='type-id-2'>
      <subrange length='2' type-id='type-id-3' id='type-id-4'/>
    </array-type-def>
    <type-decl name='unsigned long int' size-in-bits='64' id='type-id-3'/>
    <var-decl name='arg' type-id='type-id-2' mangled-name='arg'
visibility='default' filepath='/tmp/bar.c' line='1' column='1'
elf-symbol-id='arg'/>
  </abi-instr>
</abi-corpus>
$ gcc -fcommon -g -Wall -Wextra -c bar.c
$ ~/android/libabigail/build/tools/abidw bar.o
<abi-corpus path='bar.o' architecture='elf-amd-x86_64'>
  <elf-variable-symbols>
    <elf-symbol name='arg' size='8' type='object-type' binding='global-binding'
visibility='default-visibility' is-defined='yes' is-common='yes'/>
  </elf-variable-symbols>
</abi-corpus>

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27162] libabigail appears to lose declarations for common symbols

[gprocida+abigail at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27162

--- Comment #1 from Giuliano Procida <gprocida+abigail at google dot com> ---
Note that -fcommon is the default for GCC 9 and earlier.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27162] libabigail appears to lose declarations for common symbols

[gprocida at google dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27162

gprocida at google dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |gprocida at google dot com

--- Comment #2 from gprocida at google dot com ---
Still reproduces at head. The DWARF dumps are virtually identical between
-fcommon and -fno-common so I suspect the issue is more with the symbol table
or symbol lookup side of things.

-- 
You are receiving this mail because:
You are on the CC list for the bug.