[Bug default/27267] New: Assertion comparing ABIs on rawhide

[Bug default/27267] New: Assertion comparing ABIs on rawhide

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

            Bug ID: 27267
           Summary: Assertion comparing ABIs on rawhide
           Product: libabigail
           Version: unspecified
            Status: UNCONFIRMED
          Severity: normal
          Priority: P2
         Component: default
          Assignee: dodji at redhat dot com
          Reporter: bugzilla at hadess dot net
                CC: libabigail at sourceware dot org
  Target Milestone: ---

libabigail-1.8-2.fc33 on x86_64

totem-pl-parser's upstream CI pipeline uses abidiff to make sure that there
aren't unwanted ABI changes between versions.

This currently fails, as the rawhide toolchain seems to have moved to a new
version of DWARF which libabigail doesn't handle.

The error:
abidiff: abg-dwarf-reader.cc:9364: bool
abigail::dwarf_reader::compare_dies_string_attribute_value(const Dwarf_Die*,
const Dwarf_Die*, unsigned int, bool&): Assertion `__abg_cond__' failed.
ABI comparison failed: Command '['abidiff', '--headers-dir1',
'/tmp/totem-pl-parser/9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63/usr/include',
'--headers-dir2',
'/tmp/totem-pl-parser/b58c60f8fd94ecf4a2896a6a26528520bda37435/usr/include',
'--drop-private-types', '--fail-no-debug-info', '--no-added-syms',
'/tmp/totem-pl-parser/9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63/usr/lib/libtotem-plparser.so',
'/tmp/totem-pl-parser/b58c60f8fd94ecf4a2896a6a26528520bda37435/usr/lib/libtotem-plparser.so']'
died with <Signals.SIGABRT: 6>.

The repository for the library in question, although I don't think it's
necessarily a problem with just this library:
https://gitlab.gnome.org/GNOME/totem-pl-parser/

The CI pipeline:
https://gitlab.gnome.org/GNOME/totem-pl-parser/-/blob/master/.gitlab-ci.yml
if you want to reproduce the problem locally in a container.

The script:
https://gitlab.gnome.org/GNOME/totem-pl-parser/-/blob/master/.ci/check-abi

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27267] Assertion comparing ABIs on rawhide

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |NEW
     Ever confirmed|0                           |1
   Last reconfirmed|                            |2021-01-28

--- Comment #1 from dodji at redhat dot com ---
Thanks for filing the issue!

Could you please just attach the binary on which libabigail crashes, to this
bug report?  It'd would make things much quicker to reproduce and debug.

Thanks again!

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27267] Assertion comparing ABIs on rawhide

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

--- Comment #2 from Bastien Nocera <bugzilla at hadess dot net> ---
# abidiff  --drop-private-types --fail-no-debug-info --no-added-syms
/tmp/totem-pl-parser/9ccc3c78a5a41b86bdd2c9fb63ad4963e65e4f63/usr/lib/libtotem-plparser.so
/tmp/totem-pl-parser/b58c60f8fd94ecf4a2896a6a26528520bda37435/usr/lib/libtotem-plparser.so
abidiff: abg-dwarf-reader.cc:9364: bool
abigail::dwarf_reader::compare_dies_string_attribute_value(const Dwarf_Die*,
const Dwarf_Die*, unsigned int, bool&): Assertion `__abg_cond__' failed.
Aborted (core dumped)

File with the 2 shared libraries at:
https://hadess.fedorapeople.org/abidiff-crash-rawhide-bug-27267.tar.gz

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27267] Assertion comparing ABIs on rawhide

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

--- Comment #3 from dodji at redhat dot com ---
Hello,

So, I got the binaries attached and tried to reproduce the issue with the
libabigail 1.8.1 from Rawhide and Fedora 33 (they are the same code).  Here is
the output I am getting from Rawhide:

/usr/bin/abidiff
$ rpm -qf /usr/bin/abidiff
attention : Found bdb Packages database while attempting sqlite backend: using
bdb backend.
libabigail-1.8.1-1.fc34.x86_64
$ abidiff --version
abidiff: 1.8.1
$ abidiff --drop-private-types --fail-no-debug-info --no-added-syms 
libtotem-plparser.so.18.1.0 libtotem-plparser.so.18.3.4
Functions changes summary: 0 Removed, 1 Changed (8 filtered out), 0 Added (3
filtered out) functions
Variables changes summary: 0 Removed, 0 Changed, 0 Added variable

1 function with some indirect sub-type change:

  [C] 'function void totem_pl_parser_add_ignored_mimetype(TotemPlParser*, const
char*)' at totem-pl-parser.c:2409:1 has some indirect sub-type changes:
    parameter 1 of type 'TotemPlParser*' has sub-type changes:
      in pointed to type 'typedef TotemPlParser' at totem-pl-parser.h:70:1:
        underlying type 'struct {GObject parent; TotemPlParserPrivate* priv;}'
at totem-pl-parser.h:67:1 changed: 
          type size hasn't changed
          1 data member change:
            type of 'TotemPlParserPrivate* priv' changed:
              in pointed to type 'typedef TotemPlParserPrivate' at
totem-pl-parser.h:60:1:
                underlying type 'struct TotemPlParserPrivate' at
totem-pl-parser.c:260:1 changed:
                  type size changed from 320 to 384 (in bits)
                  1 data member insertion:
                    'GHashTable* TotemPlParserPrivate::ignore_globs', at offset
128 (in bits) at totem-pl-parser.c:261:1
                  2 data member changes:
                    'GMutex TotemPlParserPrivate::ignore_mutex' offset changed
from 128 to 192 (in bits) (by +64 bits)
                    'GThread* TotemPlParserPrivate::main_thread' offset changed
from 192 to 256 (in bits) (by +64 bits)

$


So I don't seem to reproduce the issue with libabigail 1.8.1 that is in
currently in testing for Fedora 33.

Do you see the same?  Or am I missing something?

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27267] Assertion comparing ABIs on rawhide

[bugzilla at hadess dot net]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

--- Comment #4 from Bastien Nocera <bugzilla at hadess dot net> ---
(In reply to dodji from comment #3)
> Hello,
> 
> So, I got the binaries attached and tried to reproduce the issue with the
> libabigail 1.8.1 from Rawhide and Fedora 33 (they are the same code).

I had tested this on rawhide. In a container on my local machine, and in the
gitlab.gnome.org CI.

The CI pipeline output for this merge request will show the errors:
https://gitlab.gnome.org/GNOME/totem-pl-parser/-/merge_requests/21

It still happens on a rawhide system updated today, both in the CI and on a
container on my system.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27267] Assertion comparing ABIs on rawhide

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED

--- Comment #5 from dodji at redhat dot com ---
Okay, I could finally reproduce the Rawhide issue.  Thanks for the hand
holding.  It seems to look different from the Fedora 33 one.

At least the Rawhide one should now be fixed by commit
https://sourceware.org/git/?p=libabigail.git;a=commit;h=e5c7fd34007daec012810601efc3481bb5823750
recently applied to the mainline branch.

It should be available in libabigail 2.0 or maybe in an intermediate 1.8.2
release before that.

I'll be trying to reproduce the Fedora 33 one now.

-- 
You are receiving this mail because:
You are on the CC list for the bug.

[Bug default/27267] Assertion comparing ABIs on rawhide

[dodji at redhat dot com]

https://sourceware.org/bugzilla/show_bug.cgi?id=27267

dodji at redhat dot com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|ASSIGNED                    |RESOLVED
         Resolution|---                         |FIXED

--- Comment #6 from dodji at redhat dot com ---
(In reply to dodji from comment #5)
> Okay, I could finally reproduce the Rawhide issue.  Thanks for the hand
> holding.  It seems to look different from the Fedora 33 one.
> 
> At least the Rawhide one should now be fixed by commit
> https://sourceware.org/git/?p=libabigail.git;a=commit;
> h=e5c7fd34007daec012810601efc3481bb5823750 recently applied to the mainline
> branch.
> 
> It should be available in libabigail 2.0 or maybe in an intermediate 1.8.2
> release before that.
> 
> I'll be trying to reproduce the Fedora 33 one now.


I have just tested that patch in the context of Fedora 33 as well, the CI
pipeline seems to work with it.

I am thus closing this problem report as the issue seems to be fixed.  It
should percolate into a package update near you soon.

Thanks your taking the time to report the issue and sorry for the
inconvenience.

-- 
You are receiving this mail because:
You are on the CC list for the bug.